]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
Simplify broadcast computation
authorDaniel Lezcano <daniel.lezcano@free.fr>
Mon, 14 Feb 2011 08:22:08 +0000 (09:22 +0100)
committerDaniel Lezcano <dlezcano@fr.ibm.com>
Mon, 14 Feb 2011 08:22:08 +0000 (09:22 +0100)
David Ward reported this computation could be written in a simpler
way.

Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
src/lxc/confile.c

index 7c7275238f124f6087f62071f6be6f95d350d707..1d30cba081bbdf4af2e2ac7cbb555c6aa826aa62 100644 (file)
@@ -423,8 +423,9 @@ static int config_network_ipv4(const char *key, char *value,
         * prefix and address
         */
        if (!bcast) {
-               int mask = htonl(INADDR_BROADCAST << (32 - inetdev->prefix));
-               inetdev->bcast.s_addr = (inetdev->addr.s_addr & mask) | ~mask;
+               inetdev->bcast.s_addr = inetdev->addr.s_addr;
+               inetdev->bcast.s_addr |=
+                       htonl(INADDR_BROADCAST >>  inetdev->prefix);
        }
 
        lxc_list_add(&netdev->ipv4, list);