]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commitdiff
mke2fs: be explicit if external journal device is not found
authorEric Sandeen <sandeen@redhat.com>
Thu, 1 Apr 2010 19:26:30 +0000 (14:26 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 12 May 2010 16:54:12 +0000 (12:54 -0400)
This for RH bug #572935 -
RFE: Misleading error message from mke2fs -J option

If the journal device UUID is typo'd or otherwise not found,
the error message looks like it's a usage() type of problem.

It'd be helpful to explicitly say that the device requested
could not be found.

Addresses-Red-Hat-Bug: #572935

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
misc/util.c

index 837d60fc838c887aa0aef56a910e8a34375f9a66..2897937294a2f48ec17956298117fb92eaf32aee 100644 (file)
@@ -207,6 +207,10 @@ void parse_journal_opts(const char *opts)
                if (strcmp(token, "device") == 0) {
                        journal_device = blkid_get_devname(NULL, arg, NULL);
                        if (!journal_device) {
+                               if (arg)
+                                       fprintf(stderr, _("\nCould not find "
+                                               "journal device matching %s\n"),
+                                               arg);
                                journal_usage++;
                                continue;
                        }