]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Use thread-context even with numatune's restrictive mode
authorMartin Kletzander <mkletzan@redhat.com>
Fri, 19 May 2023 09:52:27 +0000 (11:52 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Tue, 23 May 2023 15:04:08 +0000 (17:04 +0200)
We cannot use host-nodes attribute for it, but there is no reason for us
to skip the preallocation optimisation using thread-context in such
case.  Thankfully returning the proper nodemask from
qemuBuildMemoryBackendProps is enough to trigger this.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_command.c

index 2a6d9408f6e264d4967918a26beb202138cdece3..15383f646a242a7c8b898db32e7be3c9c91bfbdb 100644 (file)
@@ -3245,7 +3245,7 @@ qemuBuildMemoryGetPagesize(virQEMUDriverConfig *cfg,
  * @def: domain definition object
  * @mem: memory definition object
  * @force: forcibly use one of the backends
- * @nodemaskRet: [out] bitmap used to format .host-nodes attribute
+ * @nodemaskRet: [out] bitmap where the memory should be allocated
  *
  * Creates a configuration object that represents memory backend of given guest
  * NUMA node (domain @def and @mem). Use @priv->autoNodeset to fine tune the
@@ -3458,10 +3458,10 @@ qemuBuildMemoryBackendProps(virJSONValue **backendProps,
                                       "S:policy", qemuNumaPolicyTypeToString(mode),
                                       NULL) < 0)
                 return -1;
-
-            if (nodemaskRet)
-                *nodemaskRet = nodemask;
         }
+
+        if (nodemaskRet)
+            *nodemaskRet = nodemask;
     }
 
     /* If none of the following is requested... */