smbd: Remove an unnecessary talloc_strdup()

talloc_string_sub() already makes a copy first

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index 05cc118164568c84267a6595498905fb55692faf..5761725264385e80d713e24fdda1f6f591ba0135 100644 (file)
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -223,15 +223,7 @@ static NTSTATUS create_conn_struct_as_root(TALLOC_CTX *ctx,
                servicename = "Unknown Service (snum == -1)";
        }
 
-       connpath = talloc_strdup(conn, path);
-       if (!connpath) {
-               TALLOC_FREE(conn);
-               return NT_STATUS_NO_MEMORY;
-       }
-       connpath = talloc_string_sub(conn,
-                                    connpath,
-                                    "%S",
-                                    servicename);
+       connpath = talloc_string_sub(conn, path, "%S", servicename);
        if (!connpath) {
                TALLOC_FREE(conn);
                return NT_STATUS_NO_MEMORY;