]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
vfs_streams_xattr: make use of vfs_fake_fd_close()
authorStefan Metzmacher <metze@samba.org>
Fri, 18 Dec 2020 13:36:00 +0000 (14:36 +0100)
committerKarolin Seeger <kseeger@samba.org>
Wed, 13 Jan 2021 12:41:13 +0000 (12:41 +0000)
When we used vfs_fake_fd() we should use vfs_fake_fd_close()
in order to have things symetric.

That may allows us to change vfs_fake_fd() internally if required.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14596

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(back-ported from commit 40e70cbd3c3a1df9205a7b18d07784c1754cc340)

source3/modules/vfs_streams_xattr.c

index 85efe2bcc376192f0e9e34f76831b82b7602fa3d..7d0617507e3458f11b880cbdff3715e269e76e6e 100644 (file)
@@ -490,7 +490,7 @@ static int streams_xattr_open(vfs_handle_struct *handle,
 
  fail:
        if (fakefd >= 0) {
-               close(fakefd);
+               vfs_fake_fd_close(fakefd);
                fakefd = -1;
        }
 
@@ -512,7 +512,7 @@ static int streams_xattr_close(vfs_handle_struct *handle,
                return SMB_VFS_NEXT_CLOSE(handle, fsp);
        }
 
-       ret = close(fd);
+       ret = vfs_fake_fd_close(fd);
        fsp->fh->fd = -1;
 
        return ret;