]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: as3722: Move fixed assignments to 'pinctrl_desc' definition
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 11 Jun 2025 06:13:43 +0000 (08:13 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 18 Jun 2025 11:26:37 +0000 (13:26 +0200)
Assign 'struct pinctrl_desc' .pins and .npins members in definition to
make clear that number of pins is fixed and have less code in the probe.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/20250611-pinctrl-const-desc-v2-11-b11c1d650384@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-as3722.c

index 0d8c75ce20eda97627aef773342a0b63ff6114a1..ed7b2c482ff0bb6a546955c083ef7046701527b0 100644 (file)
@@ -422,6 +422,8 @@ static struct pinctrl_desc as3722_pinctrl_desc = {
        .pmxops = &as3722_pinmux_ops,
        .confops = &as3722_pinconf_ops,
        .owner = THIS_MODULE,
+       .pins = as3722_pins_desc,
+       .npins = ARRAY_SIZE(as3722_pins_desc),
 };
 
 static int as3722_gpio_get(struct gpio_chip *chip, unsigned offset)
@@ -550,8 +552,6 @@ static int as3722_pinctrl_probe(struct platform_device *pdev)
        as_pci->pin_groups = as3722_pingroups;
        as_pci->num_pin_groups = ARRAY_SIZE(as3722_pingroups);
        as3722_pinctrl_desc.name = dev_name(&pdev->dev);
-       as3722_pinctrl_desc.pins = as3722_pins_desc;
-       as3722_pinctrl_desc.npins = ARRAY_SIZE(as3722_pins_desc);
        as_pci->pctl = devm_pinctrl_register(&pdev->dev, &as3722_pinctrl_desc,
                                             as_pci);
        if (IS_ERR(as_pci->pctl)) {