]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
RISC-V: KVM: Remove unnecessary 'ret' assignment
authorQiang Ma <maqianga@uniontech.com>
Mon, 29 Dec 2025 07:25:30 +0000 (15:25 +0800)
committerAnup Patel <anup@brainfault.org>
Fri, 6 Feb 2026 13:34:05 +0000 (19:04 +0530)
If execution reaches "ret = 0" assignment in
kvm_riscv_vcpu_pmu_event_info() then it means
kvm_vcpu_write_guest() returned 0 hence ret is
already zero and does not need to be assigned 0.

Fixes: e309fd113b9f ("RISC-V: KVM: Implement get event info function")
Signed-off-by: Qiang Ma <maqianga@uniontech.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20251229072530.3075496-1-maqianga@uniontech.com
Signed-off-by: Anup Patel <anup@brainfault.org>
arch/riscv/kvm/vcpu_pmu.c

index a2fae70ee174c10c27cdcc5e5881cafc89897679..4d8d5e9aa53d40f700605ec7011ddb9dc5a58dfd 100644 (file)
@@ -494,12 +494,9 @@ int kvm_riscv_vcpu_pmu_event_info(struct kvm_vcpu *vcpu, unsigned long saddr_low
        }
 
        ret = kvm_vcpu_write_guest(vcpu, shmem, einfo, shmem_size);
-       if (ret) {
+       if (ret)
                ret = SBI_ERR_INVALID_ADDRESS;
-               goto free_mem;
-       }
 
-       ret = 0;
 free_mem:
        kfree(einfo);
 out: