]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
spi: mt65xx: Use IRQF_ONESHOT with threaded IRQ
authorFei Shao <fshao@chromium.org>
Wed, 17 Dec 2025 10:10:47 +0000 (18:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Jan 2026 15:31:28 +0000 (16:31 +0100)
[ Upstream commit 8c04b77f87e6e321ae6acd28ce1de5553916153f ]

This driver is migrated to use threaded IRQ since commit 5972eb05ca32
("spi: spi-mt65xx: Use threaded interrupt for non-SPIMEM transfer"), and
we almost always want to disable the interrupt line to avoid excess
interrupts while the threaded handler is processing SPI transfer.
Use IRQF_ONESHOT for that purpose.

In practice, we see MediaTek devices show SPI transfer timeout errors
when communicating with ChromeOS EC in certain scenarios, and with
IRQF_ONESHOT, the issue goes away.

Signed-off-by: Fei Shao <fshao@chromium.org>
Link: https://patch.msgid.link/20251217101131.1975131-1-fshao@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-mt65xx.c

index dfee244fc3173cb868f253247a9eb8b5bfcf0c25..5532ace0b133480d42ee839754728afa26fcffe5 100644 (file)
@@ -1266,7 +1266,7 @@ static int mtk_spi_probe(struct platform_device *pdev)
 
        ret = devm_request_threaded_irq(dev, irq, mtk_spi_interrupt,
                                        mtk_spi_interrupt_thread,
-                                       IRQF_TRIGGER_NONE, dev_name(dev), host);
+                                       IRQF_ONESHOT, dev_name(dev), host);
        if (ret)
                return dev_err_probe(dev, ret, "failed to register irq\n");