]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Don't update vol details after build
authorDavid Allan <dallan@redhat.com>
Wed, 6 Jan 2010 16:53:15 +0000 (17:53 +0100)
committerDaniel Veillard <veillard@redhat.com>
Wed, 6 Jan 2010 16:53:15 +0000 (17:53 +0100)
This patch removes the call to vol update after the volume build completes.
The update call is currently meaningless anyway because the vol build is passed
a copy of the definition, so the update result is thrown away.  More
importantly, if the user specified a selinux label for the volume, the update
call results in a double free of the label
* src/storage/storage_backend_fs.c: remove the update call

src/storage/storage_backend_fs.c

index b7d4bd6d93a6e6d33794a021a88ebc78bc2ccbcd..4fe40b379d7b268335da29d58f561d926284ae22 100644 (file)
@@ -822,14 +822,6 @@ _virStorageBackendFileSystemVolBuild(virConnectPtr conn,
         return -1;
     }
 
-    /* Refresh allocation / permissions info, but not capacity */
-    if (virStorageBackendUpdateVolTargetInfoFD(conn, &vol->target, fd,
-                                               &vol->allocation,
-                                               NULL) < 0) {
-        close(fd);
-        return -1;
-    }
-
     if (close(fd) < 0) {
         virReportSystemError(conn, errno,
                              _("cannot close file '%s'"),