Take out nonnull hint on _fr_dbuff_init() for coverity (CIDs below) (#4697)

Coverity assumes that the nonnull means we'll dereference the end
pointer... so leave it out when coverity runs.

CIDs: 1503895, 1503905, 1503907, 1503914, 1503915, 1503924
      1503956, 1503970, 1503973, 1503979, 1503980, 1503988
      1504000, 1504034, 1504035, 1504039, 1504040, 1504059

diff --git a/src/lib/util/dbuff.h b/src/lib/util/dbuff.h
index 967f7a2b44d75a9913c68943f09048f239c252ed..48890195793ab0d6ae276168dfc697cc8d17d439 100644 (file)
--- a/src/lib/util/dbuff.h
+++ b/src/lib/util/dbuff.h
@@ -327,7 +327,11 @@ DIAG_OFF(maybe-uninitialized)
 /** Does the actual work of initialising a dbuff
  * @private
  */
-static inline CC_HINT(nonnull) void _fr_dbuff_init(fr_dbuff_t *out, uint8_t const *start, uint8_t const *end, bool is_const)
+static inline
+#ifndef __COVERITY__
+CC_HINT(nonnull)
+#endif
+void _fr_dbuff_init(fr_dbuff_t *out, uint8_t const *start, uint8_t const *end, bool is_const)
 {
        if (unlikely(end < start)) end = start; /* Could be an assert? */