]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mfd: max77759: Drop use of irqd_get_trigger_type
authorAndré Draszik <andre.draszik@linaro.org>
Wed, 17 Dec 2025 12:03:58 +0000 (12:03 +0000)
committerLee Jones <lee@kernel.org>
Thu, 22 Jan 2026 14:22:38 +0000 (14:22 +0000)
irqd_get_trigger_type() is meant for cases where the driver needs to
know the configured IRQ trigger type and e.g. wants to change its
behaviour accordingly. Furthermore, platform support code, e.g. DT
handling, will configure the hardware based on that, and drivers don't
need to pass the trigger type into request_irq() and friends.

Drop the use from this driver, as it doesn't need to know the trigger
type.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://patch.msgid.link/20251217-max77759-mfd-irq-trigger-v1-1-e7d29f84d34f@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/max77759.c

index 6cf6306c4a3b25655ff08077b6f94316ab8cae04..a7efe233ec8c829eac20c5ef65bc61856dc8e06e 100644 (file)
@@ -587,9 +587,7 @@ static int max77759_add_chained_charger(struct i2c_client *client,
 static int max77759_probe(struct i2c_client *client)
 {
        struct regmap_irq_chip_data *irq_chip_data_pmic;
-       struct irq_data *irq_data;
        struct max77759 *max77759;
-       unsigned long irq_flags;
        unsigned int pmic_id;
        int ret;
 
@@ -628,16 +626,8 @@ static int max77759_probe(struct i2c_client *client)
                        return ret;
        }
 
-       irq_data = irq_get_irq_data(client->irq);
-       if (!irq_data)
-               return dev_err_probe(&client->dev, -EINVAL,
-                                    "invalid IRQ: %d\n", client->irq);
-
-       irq_flags = IRQF_ONESHOT | IRQF_SHARED;
-       irq_flags |= irqd_get_trigger_type(irq_data);
-
        ret = devm_regmap_add_irq_chip(&client->dev, max77759->regmap_top,
-                                      client->irq, irq_flags, 0,
+                                      client->irq, IRQF_ONESHOT | IRQF_SHARED, 0,
                                       &max77759_pmic_irq_chip,
                                       &irq_chip_data_pmic);
        if (ret)