]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: dmi: Constify 'struct bin_attribute'
authorThomas Weißschuh <linux@weissschuh.net>
Sat, 25 Jan 2025 10:12:16 +0000 (11:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Feb 2025 08:20:30 +0000 (09:20 +0100)
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20250125-sysfs-const-bin_attr-dmi-v2-3-ece1895936f4@weissschuh.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/dmi-sysfs.c

index 6baa921a6664d087049bc15bf44a32c520853526..9cc963b2edc0e9a0e9a7b03af7174c08e8ea9422 100644 (file)
@@ -432,7 +432,7 @@ static ssize_t dmi_sel_raw_read_helper(struct dmi_sysfs_entry *entry,
 }
 
 static ssize_t raw_event_log_read(struct file *filp, struct kobject *kobj,
-                                 struct bin_attribute *bin_attr,
+                                 const struct bin_attribute *bin_attr,
                                  char *buf, loff_t pos, size_t count)
 {
        struct dmi_sysfs_entry *entry = to_entry(kobj->parent);
@@ -445,7 +445,7 @@ static ssize_t raw_event_log_read(struct file *filp, struct kobject *kobj,
        return find_dmi_entry(entry, dmi_sel_raw_read_helper, &state);
 }
 
-static BIN_ATTR_ADMIN_RO(raw_event_log, 0);
+static const BIN_ATTR_ADMIN_RO(raw_event_log, 0);
 
 static int dmi_system_event_log(struct dmi_sysfs_entry *entry)
 {
@@ -536,7 +536,7 @@ static ssize_t dmi_entry_raw_read_helper(struct dmi_sysfs_entry *entry,
 
 static ssize_t raw_read(struct file *filp,
                        struct kobject *kobj,
-                       struct bin_attribute *bin_attr,
+                       const struct bin_attribute *bin_attr,
                        char *buf, loff_t pos, size_t count)
 {
        struct dmi_sysfs_entry *entry = to_entry(kobj);