]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
rust: auxiliary: use `pin_init::zeroed()` for device ID
authorAtharv Dubey <atharvd440@gmail.com>
Sat, 29 Nov 2025 12:47:06 +0000 (18:17 +0530)
committerDanilo Krummrich <dakr@kernel.org>
Sun, 25 Jan 2026 22:09:09 +0000 (23:09 +0100)
Replace the previous `unsafe { core::mem::zeroed() }` initialization
for `bindings::auxillary_device_id` with `pin_init::zeroed()`. This removes
the explicit unsafe block and uses the safer pinned zero-initialization
helper.

Suggested-by: Benno Lossin <lossin@kernel.org>
Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
Link: https://github.com/Rust-for-Linux/linux/issues/1189
Link: https://patch.msgid.link/20251129124706.26263-1-atharvd440@gmail.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
rust/kernel/auxiliary.rs

index d2890a2c543a816c69c97cbb58cbe0690c1764fa..c0d34f53a399f82c893966c474d3571b1755bf75 100644 (file)
@@ -121,12 +121,7 @@ impl DeviceId {
         let name = name.to_bytes_with_nul();
         let modname = modname.to_bytes_with_nul();
 
-        // TODO: Replace with `bindings::auxiliary_device_id::default()` once stabilized for
-        // `const`.
-        //
-        // SAFETY: FFI type is valid to be zero-initialized.
-        let mut id: bindings::auxiliary_device_id = unsafe { core::mem::zeroed() };
-
+        let mut id: bindings::auxiliary_device_id = pin_init::zeroed();
         let mut i = 0;
         while i < modname.len() {
             id.name[i] = modname[i];