]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: rockchip: Correctly describe the ethernet phy on rk3368-lion
authorHeiko Stuebner <heiko.stuebner@cherry.de>
Mon, 20 Oct 2025 10:07:57 +0000 (12:07 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Mon, 22 Dec 2025 13:47:49 +0000 (14:47 +0100)
So far, the board used the phy implicitly using the deprecated snps reset
properties. Improve that and describe the PHY correctly under the new
mdio node.

Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Link: https://patch.msgid.link/20251020100757.3669681-4-heiko@sntech.de
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi

index 8ccc3184a83628ef09538e4f2a2168872d8408e6..61c52bd91784f9dc99496dd3210c42fe0e80618c 100644 (file)
        assigned-clocks = <&cru SCLK_MAC>;
        assigned-clock-parents = <&ext_gmac>;
        clock_in_out = "input";
+       phy-handle = <&vsc8531_2>;
        phy-supply = <&vcc33_io>;
        phy-mode = "rgmii";
        pinctrl-names = "default";
        pinctrl-0 = <&rgmii_pins>;
-       snps,reset-active-low;
-       snps,reset-delays-us = <0 10000 50000>;
-       snps,reset-gpio = <&gpio3 RK_PB3 GPIO_ACTIVE_LOW>;
        tx_delay = <0x10>;
        rx_delay = <0x10>;
        status = "okay";
        status = "okay";
 };
 
+&mdio {
+       vsc8531_2: ethernet-phy@0 {
+               compatible = "ethernet-phy-ieee802.3-c22";
+               reg = <0x0>;
+               pinctrl-names = "default";
+               pinctrl-0 = <&phy_rst>;
+               reset-assert-us = <10000>;
+               reset-deassert-us = <50000>;
+               reset-gpios = <&gpio3 RK_PB3 GPIO_ACTIVE_LOW>;
+       };
+};
+
 &pinctrl {
+       ethernet {
+               phy_rst: phy-rst {
+                       rockchip,pins = <3 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>;
+               };
+       };
+
        leds {
                module_led_pins: module-led-pins {
                        rockchip,pins =