crypto: engine - Use unregister_* in register_{aeads,ahashes,skciphers}

Replace the for loops with calls to unregister_aeads(),
unregister_ahashes(), and unregister_skciphers(), respectively. Return
'ret' immediately and remove the goto statements to simplify the error
handling code.  No functional changes.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/crypto/crypto_engine.c b/crypto/crypto_engine.c
index 18e1689efe127ca29b8faf4f9dee775d92046745..e124bb77395824a80570bf82f011f6f66009de04 100644 (file)
--- a/crypto/crypto_engine.c
+++ b/crypto/crypto_engine.c
@@ -524,16 +524,13 @@ int crypto_engine_register_aeads(struct aead_engine_alg *algs, int count)
 
        for (i = 0; i < count; i++) {
                ret = crypto_engine_register_aead(&algs[i]);
-               if (ret)
-                       goto err;
+               if (ret) {
+                       crypto_engine_unregister_aeads(algs, i);
+                       return ret;
+               }
        }
 
        return 0;
-
-err:
-       crypto_engine_unregister_aeads(algs, i);
-
-       return ret;
 }
 EXPORT_SYMBOL_GPL(crypto_engine_register_aeads);
 
@@ -566,16 +563,13 @@ int crypto_engine_register_ahashes(struct ahash_engine_alg *algs, int count)
 
        for (i = 0; i < count; i++) {
                ret = crypto_engine_register_ahash(&algs[i]);
-               if (ret)
-                       goto err;
+               if (ret) {
+                       crypto_engine_unregister_ahashes(algs, i);
+                       return ret;
+               }
        }
 
        return 0;
-
-err:
-       crypto_engine_unregister_ahashes(algs, i);
-
-       return ret;
 }
 EXPORT_SYMBOL_GPL(crypto_engine_register_ahashes);
 
@@ -638,16 +632,13 @@ int crypto_engine_register_skciphers(struct skcipher_engine_alg *algs,
 
        for (i = 0; i < count; i++) {
                ret = crypto_engine_register_skcipher(&algs[i]);
-               if (ret)
-                       goto err;
+               if (ret) {
+                       crypto_engine_unregister_skciphers(algs, i);
+                       return ret;
+               }
        }
 
        return 0;
-
-err:
-       crypto_engine_unregister_skciphers(algs, i);
-
-       return ret;
 }
 EXPORT_SYMBOL_GPL(crypto_engine_register_skciphers);