]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: sm750fb: fix checkpatch warning architecture specific defines should be...
authorMichael Anckaert <michael.anckaert@gmail.com>
Wed, 12 Feb 2025 10:12:40 +0000 (10:12 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Feb 2025 15:54:06 +0000 (16:54 +0100)
Replace architecture-specific defines with CONFIG_X86 checks to improve
portability and adhere to kernel coding standards.

Fixes checkpatch warning:
- CHECK: architecture specific defines should be avoided.

Changes made:
- Using CONFIG_X86 instead of i386 and x86.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Michael Anckaert <michael.anckaert@gmail.com>
Link: https://lore.kernel.org/r/Z6x0GEM5sxcruYlS@michael-devbox
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm750fb/ddk750_chip.c

index 02860d3ec365c9c076ed39fcbe00b02a862f33f0..025dae3756aad1bd74888a38025cda081f31cc09 100644 (file)
@@ -228,8 +228,8 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
                reg = peek32(VGA_CONFIGURATION);
                reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
                poke32(VGA_CONFIGURATION, reg);
+#ifdef CONFIG_X86
        } else {
-#if defined(__i386__) || defined(__x86_64__)
                /* set graphic mode via IO method */
                outb_p(0x88, 0x3d4);
                outb_p(0x06, 0x3d5);