]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
remote: Drop useless cleanup in remoteDispatchNodeGet{CPU,Memory}Stats
authorJiri Denemark <jdenemar@redhat.com>
Wed, 25 Jan 2023 14:25:06 +0000 (15:25 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Thu, 26 Jan 2023 15:11:09 +0000 (16:11 +0100)
The function cannot fail once it starts populating
ret->params.params_val[i].field.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/remote/remote_daemon_dispatch.c

index 54afa5c2f4832e7a201bcba05c4789fd08ad9acc..250eb51e6bfc87c775e86294910c1aa0fefce693 100644 (file)
@@ -3310,11 +3310,6 @@ remoteDispatchNodeGetCPUStats(virNetServer *server G_GNUC_UNUSED,
  cleanup:
     if (rv < 0) {
         virNetMessageSaveError(rerr);
-        if (ret->params.params_val) {
-            for (i = 0; i < nparams; i++)
-                VIR_FREE(ret->params.params_val[i].field);
-            VIR_FREE(ret->params.params_val);
-        }
     }
     VIR_FREE(params);
     return rv;
@@ -3377,11 +3372,6 @@ remoteDispatchNodeGetMemoryStats(virNetServer *server G_GNUC_UNUSED,
  cleanup:
     if (rv < 0) {
         virNetMessageSaveError(rerr);
-        if (ret->params.params_val) {
-            for (i = 0; i < nparams; i++)
-                VIR_FREE(ret->params.params_val[i].field);
-            VIR_FREE(ret->params.params_val);
-        }
     }
     VIR_FREE(params);
     return rv;