insane: error out on UNPACKDIR = WORKDIR

as this will clear WORKDIR and create race conditions
across various handling tasks

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index 822d190a3046b81a0839f072bc460a41c867f92e..bd05da0378e6bd7aeedce39875c52ef8f54db8e6 100644 (file)
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -1596,10 +1596,13 @@ python () {
     sourcedir = d.getVar("S")
     builddir = d.getVar("B")
     workdir = d.getVar("WORKDIR")
+    unpackdir = d.getVar("UNPACKDIR")
     if sourcedir == workdir:
         bb.fatal("Using S = ${WORKDIR} is no longer supported")
     if builddir == workdir:
         bb.fatal("Using B = ${WORKDIR} is no longer supported")
+    if unpackdir == workdir:
+        bb.fatal("Using UNPACKDIR = ${WORKDIR} is not supported")
     if sourcedir[-1] == '/':
         bb.warn("Recipe %s sets S variable with trailing slash '%s', remove it" % (d.getVar("PN"), d.getVar("S")))
     if builddir[-1] == '/':