]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: use g_strdupv instead of virStringListCopy
authorJán Tomko <jtomko@redhat.com>
Sun, 2 Aug 2020 11:33:55 +0000 (13:33 +0200)
committerJán Tomko <jtomko@redhat.com>
Mon, 3 Aug 2020 13:37:36 +0000 (15:37 +0200)
Also remove the temporary variable - even virStringListCopy
aborts on OOM now.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/conf/domain_capabilities.c

index 837b004334d023823558690e6f2e04dc1908e086..4b867dd99752e7bd1cb06c179c280c206d92e1d1 100644 (file)
@@ -199,14 +199,10 @@ virDomainCapsCPUModelsAdd(virDomainCapsCPUModelsPtr cpuModels,
                           char **blockers)
 {
     g_autofree char * nameCopy = NULL;
-    VIR_AUTOSTRINGLIST blockersCopy = NULL;
     virDomainCapsCPUModelPtr cpu;
 
     nameCopy = g_strdup(name);
 
-    if (virStringListCopy(&blockersCopy, (const char **)blockers) < 0)
-        return -1;
-
     if (VIR_RESIZE_N(cpuModels->models, cpuModels->nmodels_max,
                      cpuModels->nmodels, 1) < 0)
         return -1;
@@ -216,7 +212,7 @@ virDomainCapsCPUModelsAdd(virDomainCapsCPUModelsPtr cpuModels,
 
     cpu->usable = usable;
     cpu->name = g_steal_pointer(&nameCopy);
-    cpu->blockers = g_steal_pointer(&blockersCopy);
+    cpu->blockers = g_strdupv(blockers);
 
     return 0;
 }