]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: virtuser: actually use the "trimmed" local variable
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 9 Jul 2024 15:12:34 +0000 (17:12 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 10 Jul 2024 12:17:31 +0000 (14:17 +0200)
This variable is set with the intention of being passed to the
subsequent strcmp() but something went wrong and it was left unused. Use
it now.

Fixes: 91581c4b3f29 ("gpio: virtuser: new virtual testing driver for the GPIO API")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407092245.BPnW2mr6-lkp@intel.com/
Link: https://lore.kernel.org/r/20240709151235.90523-1-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-virtuser.c

index 2ac09c6a376348097bafb283b831ce674f0c9d3e..0e0d55da4f0116c0cd94dd6c5c42e182542fc815 100644 (file)
@@ -406,12 +406,12 @@ static ssize_t gpio_virtuser_direction_do_write(struct file *file,
 
        trimmed = strim(buf);
 
-       if (strcmp(buf, "input") == 0) {
+       if (strcmp(trimmed, "input") == 0) {
                dir = 1;
-       } else if (strcmp(buf, "output-high") == 0) {
+       } else if (strcmp(trimmed, "output-high") == 0) {
                dir = 0;
                val = 1;
-       } else if (strcmp(buf, "output-low") == 0) {
+       } else if (strcmp(trimmed, "output-low") == 0) {
                dir = val = 0;
        } else {
                return -EINVAL;