]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
binder: use kstrdup() in binderfs_binder_device_create()
authorDmitry Antipov <dmantipov@yandex.ru>
Thu, 26 Jun 2025 07:30:53 +0000 (10:30 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Jul 2025 12:11:20 +0000 (14:11 +0200)
In 'binderfs_binder_device_create()', use 'kstrdup()' to copy the
newly created device's name, thus making the former a bit simpler.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Carlos Llamas <cmllamas@google.com>
Reviewed-by: "Tiffany Y. Yang" <ynaffit@google.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Link: https://lore.kernel.org/r/20250626073054.7706-1-dmantipov@yandex.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binderfs.c

index 024275dbfdd8944462e3939c97cc9ab88f3ea80b..4f827152d18eeca782328b91a527b654ba514f07 100644 (file)
@@ -117,7 +117,6 @@ static int binderfs_binder_device_create(struct inode *ref_inode,
        struct dentry *dentry, *root;
        struct binder_device *device;
        char *name = NULL;
-       size_t name_len;
        struct inode *inode = NULL;
        struct super_block *sb = ref_inode->i_sb;
        struct binderfs_info *info = sb->s_fs_info;
@@ -161,9 +160,7 @@ static int binderfs_binder_device_create(struct inode *ref_inode,
        inode->i_gid = info->root_gid;
 
        req->name[BINDERFS_MAX_NAME] = '\0'; /* NUL-terminate */
-       name_len = strlen(req->name);
-       /* Make sure to include terminating NUL byte */
-       name = kmemdup(req->name, name_len + 1, GFP_KERNEL);
+       name = kstrdup(req->name, GFP_KERNEL);
        if (!name)
                goto err;