netfilter: nft_meta: fix iifgroup matching

[ Upstream commit 78470d9d0d9f2f8d16f28382a4071568e839c0d5 ]

iifgroup matching erroneously checks the output interface.

Fixes: 8724e819cc9a ("netfilter: nft_meta: move all interface related keys to helper")
Reported-by: Demi M. Obenour <demiobenour@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c
index 951b6e87ed5d9fd4de57aff772a2a9f2d58b0d2a..7bc6537f3ccb58ef084a036216d049723c357734 100644 (file)
--- a/net/netfilter/nft_meta.c
+++ b/net/netfilter/nft_meta.c
@@ -253,7 +253,7 @@ static bool nft_meta_get_eval_ifname(enum nft_meta_keys key, u32 *dest,
                        return false;
                break;
        case NFT_META_IIFGROUP:
-               if (!nft_meta_store_ifgroup(dest, nft_out(pkt)))
+               if (!nft_meta_store_ifgroup(dest, nft_in(pkt)))
                        return false;
                break;
        case NFT_META_OIFGROUP: