]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpib: gpio: Unify *allocate_private usage
authorDominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Fri, 16 Jan 2026 17:48:24 +0000 (17:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Jan 2026 15:04:07 +0000 (16:04 +0100)
Use the return value of allocate_private in calling code as early return
value in case of error.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://patch.msgid.link/20260116174647.317256-14-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpib/gpio/gpib_bitbang.c

index 62adcab1ddfbc2e3799fae9e71e7fcdad23027d0..ba99d6c95ddf1be3ded5085d6f9cd45254219fd7 100644 (file)
@@ -1205,14 +1205,15 @@ static void bb_detach(struct gpib_board *board)
 static int bb_attach(struct gpib_board *board, const struct gpib_board_config *config)
 {
        struct bb_priv *priv;
-       int retval = 0;
+       int retval;
 
        dbg_printk(2, "%s\n", "Enter ...");
 
        board->status = 0;
 
-       if (allocate_private(board))
-               return -ENOMEM;
+       retval = allocate_private(board);
+       if (retval)
+               return retval;
        priv = board->private_data;
        priv->direction = -1;
        priv->t1_delay = 2000;