]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: Export std::__basic_file::native_handle as GLIBCXX_3.4.33 [PR114692]
authorJonathan Wakely <jwakely@redhat.com>
Thu, 11 Apr 2024 11:28:25 +0000 (12:28 +0100)
committerJonathan Wakely <jwakely@redhat.com>
Thu, 11 Apr 2024 14:22:33 +0000 (15:22 +0100)
I added this new symbol in the wrong version. GLIBCXX_3.4.32 was
already used for the GCC 13.2.0 release, so the new symbol should have
been in a new GLIBCXX_3.4.33 version.

Additionally, the pattern doesn't need to use [cw] because we only ever
use __basic_file<char>, even for std::basic_filebuf<wchar_t>.

libstdc++-v3/ChangeLog:

PR libstdc++/114692
* config/abi/pre/gnu.ver (GLIBCXX_3.4.32): Move new exports for
__basic_file::native_handle to ...
(GLIBCXX_3.4.33): ... here. Adjust to not match wchar_t
specialization, which isn't used.
* testsuite/util/testsuite_abi.cc: Add GLIBCXX_3.4.33 and update
latest version check.

libstdc++-v3/config/abi/pre/gnu.ver
libstdc++-v3/testsuite/util/testsuite_abi.cc

index db20d75b68eff0e2e6a33120b763b1cc96ec11ea..31449b5b87b82a790d9754dfde1197d7820898b1 100644 (file)
@@ -2516,13 +2516,18 @@ GLIBCXX_3.4.31 {
 
 } GLIBCXX_3.4.30;
 
+# GCC 13.2.0
 GLIBCXX_3.4.32 {
     _ZSt21ios_base_library_initv;
     _ZNSt7__cxx1112basic_stringI[cw]St11char_traitsI[cw]ESaI[cw]EE11_S_allocateERS3_[jmy];
-    # std::basic_file<>::native_handle()
-    _ZNKSt12__basic_fileI[cw]E13native_handleEv;
 } GLIBCXX_3.4.31;
 
+# GCC 14.1.0
+GLIBCXX_3.4.33 {
+    # std::basic_file<char>::native_handle()
+    _ZNKSt12__basic_fileIcE13native_handleEv;
+} GLIBCXX_3.4.32;
+
 # Symbols in the support library (libsupc++) have their own tag.
 CXXABI_1.3 {
 
index 4f3846b9cc20894f0af31c8029d14e1fc584d1ba..e4bf3cdc8e07437caf66faa894ab85640a7b1e1e 100644 (file)
@@ -214,6 +214,7 @@ check_version(symbol& test, bool added)
       known_versions.push_back("GLIBCXX_3.4.30");
       known_versions.push_back("GLIBCXX_3.4.31");
       known_versions.push_back("GLIBCXX_3.4.32");
+      known_versions.push_back("GLIBCXX_3.4.33");
       known_versions.push_back("GLIBCXX_LDBL_3.4.31");
       known_versions.push_back("GLIBCXX_IEEE128_3.4.29");
       known_versions.push_back("GLIBCXX_IEEE128_3.4.30");
@@ -253,7 +254,7 @@ check_version(symbol& test, bool added)
        test.version_status = symbol::incompatible;
 
       // Check that added symbols are added in the latest pre-release version.
-      bool latestp = (test.version_name == "GLIBCXX_3.4.32"
+      bool latestp = (test.version_name == "GLIBCXX_3.4.33"
                     || test.version_name == "CXXABI_1.3.15"
                     || test.version_name == "CXXABI_FLOAT128"
                     || test.version_name == "CXXABI_TM_1");