coverity: CID 1362011: Control flow issues (DEADCODE)

diff --git a/src/app-layer-htp-body.c b/src/app-layer-htp-body.c
index b4ba2ffbeaf7760822e2c69eccbc545d3df3e673..bfb9ba73af291e80d13b3730da424f0970e1372b 100644 (file)
--- a/src/app-layer-htp-body.c
+++ b/src/app-layer-htp-body.c
@@ -96,8 +96,9 @@ int HtpBodyAppendChunk(const HTPCfgDir *hcfg, HtpBody *body,
     if (body->first == NULL) {
         /* New chunk */
         bd = (HtpBodyChunk *)HTPCalloc(1, sizeof(HtpBodyChunk));
-        if (bd == NULL)
-            goto error;
+        if (bd == NULL) {
+            SCReturnInt(-1);
+        }
 
         StreamingBufferAppend(body->sb, &bd->sbseg, data, len);
 
@@ -106,8 +107,9 @@ int HtpBodyAppendChunk(const HTPCfgDir *hcfg, HtpBody *body,
         body->content_len_so_far = len;
     } else {
         bd = (HtpBodyChunk *)HTPCalloc(1, sizeof(HtpBodyChunk));
-        if (bd == NULL)
-            goto error;
+        if (bd == NULL) {
+            SCReturnInt(-1);
+        }
 
         StreamingBufferAppend(body->sb, &bd->sbseg, data, len);
 
@@ -119,12 +121,6 @@ int HtpBodyAppendChunk(const HTPCfgDir *hcfg, HtpBody *body,
     SCLogDebug("body %p", body);
 
     SCReturnInt(0);
-
-error:
-    if (bd != NULL) {
-        HTPFree(bd, sizeof(HtpBodyChunk));
-    }
-    SCReturnInt(-1);
 }
 
 /**