lib/namespace: fix ip -all netns return code

When ip -all netns {del,exec} are called and no netns is present, ip
exit with status 0. However this does not happen if no netns has been
created since boot time: in that case, indeed, the NETNS_RUN_DIR is not
present and netns_foreach() exit with code 1.

$ ls /var/run/netns
ls: cannot access '/var/run/netns': No such file or directory
$ ip -all netns exec ip link show
$ echo $?
1
$ ip -all netns del
$ echo $?
1
$ ip netns add test
$ ip netns del test
$ ip -all netns del
$ echo $?
0
$ ls -a /var/run/netns
.  ..

This leaves us in the unpleasant situation where the same command, when
no netns is present, does the same stuff (in this case, nothing), but
exit with two different statuses.

Fix this treating ENOENT in a different way from other errors, similarly
to what we already do in ipnetns.c netns_identify_pid()

Fixes: e998e118ddc3 ("lib: Exec func on each netns")
Reported-by: Jianlin Shi <jishi@redhat.com>
Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

diff --git a/lib/namespace.c b/lib/namespace.c
index 06ae0a48c2243afa4847013a022504dc420a1b45..45a7deddb6c45803105de7fbe8786b5b2075b2c5 100644 (file)
--- a/lib/namespace.c
+++ b/lib/namespace.c
@@ -122,8 +122,14 @@ int netns_foreach(int (*func)(char *nsname, void *arg), void *arg)
        struct dirent *entry;
 
        dir = opendir(NETNS_RUN_DIR);
-       if (!dir)
+       if (!dir) {
+               if (errno == ENOENT)
+                       return 0;
+
+               fprintf(stderr, "Failed to open directory %s: %s\n",
+                       NETNS_RUN_DIR, strerror(errno));
                return -1;
+       }
 
        while ((entry = readdir(dir)) != NULL) {
                if (strcmp(entry->d_name, ".") == 0)