]> git.ipfire.org Git - thirdparty/vuejs/router.git/commitdiff
chore: remove old todos
authorEduardo San Martin Morote <posva13@gmail.com>
Mon, 2 May 2022 15:16:48 +0000 (17:16 +0200)
committerEduardo San Martin Morote <posva@users.noreply.github.com>
Thu, 30 Jun 2022 07:59:00 +0000 (09:59 +0200)
playground/router.ts
src/navigationGuards.ts
src/types/index.ts

index 230b187cae97c9537fd6cf03892121e8951eb834..45860e8629766fea5c1947dda2a56694081f15f4 100644 (file)
@@ -167,7 +167,6 @@ export const router = createRouter({
     if (savedPosition) {
       return savedPosition
     } else {
-      // TODO: check if parent in common that works with alias
       if (to.matched.every((record, i) => from.matched[i] !== record))
         return { left: 0, top: 0 }
     }
index 6ce874779434883ee269012af200b18d96393dc8..b0b7fdff03c06a529cdb84232df94c00de593038 100644 (file)
@@ -194,7 +194,6 @@ export function guardToPromiseFn(
             }
             return resolvedValue
           })
-          // TODO: test me!
         } else if (guardReturn !== undefined) {
           // @ts-expect-error: _called is added at canOnlyBeCalledOnce
           if (!next._called) {
index 786cece51618147abc6848413d08a9d15963a0dd..b974d8f9203ffb1dde9c880ab2693343fd99336a 100644 (file)
@@ -464,7 +464,6 @@ export interface NavigationHookAfter {
   (
     to: RouteLocationNormalized,
     from: RouteLocationNormalized,
-    // TODO: move these types to a different file
     failure?: NavigationFailure | void
   ): any
 }