]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Prettify output of debug_dwarf_die
authorTom Tromey <tromey@adacore.com>
Thu, 28 Mar 2024 19:22:34 +0000 (13:22 -0600)
committerTom Tromey <tromey@adacore.com>
Tue, 2 Apr 2024 14:57:24 +0000 (08:57 -0600)
When debugging gcc, I tried calling debug_dwarf_die and I saw this
output:

      DW_AT_location: location descriptor:
        (0x7fffe9c2e870) DW_OP_dup 0, 0
        (0x7fffe9c2e8c0) DW_OP_bra location descriptor (0x7fffe9c2e640)
, 0
        (0x7fffe9c2e820) DW_OP_lit4 4, 0
        (0x7fffe9c2e910) DW_OP_skip location descriptor (0x7fffe9c2e9b0)
, 0
        (0x7fffe9c2e640) DW_OP_dup 0, 0

I think those ", 0" should not appear on their own lines.  The issue
seems to be that print_dw_val should not generally emit a newline,
except when recursing.

gcc/ChangeLog

* dwarf2out.cc (print_dw_val) <dw_val_class_loc>: Don't
print newline when not recursing.

gcc/dwarf2out.cc

index 8f18bc4fe64becedb1204f68d8d00a3cfca6a410..1b0e8b5a5b298fef4b895970ca301305eadc3f3f 100644 (file)
@@ -6651,7 +6651,7 @@ print_dw_val (dw_val_node *val, bool recurse, FILE *outfile)
     case dw_val_class_loc:
       fprintf (outfile, "location descriptor");
       if (val->v.val_loc == NULL)
-       fprintf (outfile, " -> <null>\n");
+       fprintf (outfile, " -> <null>");
       else if (recurse)
        {
          fprintf (outfile, ":\n");
@@ -6662,9 +6662,9 @@ print_dw_val (dw_val_node *val, bool recurse, FILE *outfile)
       else
        {
          if (flag_dump_noaddr || flag_dump_unnumbered)
-           fprintf (outfile, " #\n");
+           fprintf (outfile, " #");
          else
-           fprintf (outfile, " (%p)\n", (void *) val->v.val_loc);
+           fprintf (outfile, " (%p)", (void *) val->v.val_loc);
        }
       break;
     case dw_val_class_loc_list: