]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: airoha: Fix a NULL vs IS_ERR() bug in airoha_npu_run_firmware()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 15 Jul 2025 23:01:10 +0000 (18:01 -0500)
committerJakub Kicinski <kuba@kernel.org>
Fri, 18 Jul 2025 01:36:56 +0000 (18:36 -0700)
The devm_ioremap_resource() function returns error pointers.  It never
returns NULL.  Update the check to match.

Fixes: e27dba1951ce ("net: Use of_reserved_mem_region_to_resource{_byname}() for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/fc6d194e-6bf5-49ca-bc77-3fdfda62c434@sabinyo.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/airoha/airoha_npu.c

index bda3c93e826112b03ad742cf37a979637af3eb0c..9ab964c536e11173e3e3bb4854b4f886c75a0051 100644 (file)
@@ -179,8 +179,8 @@ static int airoha_npu_run_firmware(struct device *dev, void __iomem *base,
        }
 
        addr = devm_ioremap_resource(dev, res);
-       if (!addr) {
-               ret = -ENOMEM;
+       if (IS_ERR(addr)) {
+               ret = PTR_ERR(addr);
                goto out;
        }