]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
vala: Don't unconditionally expect ObjectType of Class
authorRico Tzschichholz <ricotz@ubuntu.com>
Sat, 30 Jul 2022 09:18:40 +0000 (11:18 +0200)
committerRico Tzschichholz <ricotz@ubuntu.com>
Wed, 10 Aug 2022 14:07:44 +0000 (16:07 +0200)
Fixes https://gitlab.gnome.org/GNOME/vala/issues/1341

tests/Makefile.am
tests/semantic/methodcall-invocation-invalid.test [new file with mode: 0644]
vala/valamethodcall.vala

index 32d2c56419ee5e671119bdbbaa5fcecbbc0fa2d4..3733c0706f7b83348ef83ce818a8c22e2d4cc5e1 100644 (file)
@@ -1161,6 +1161,7 @@ TESTS = \
        semantic/method-virtual-body.test \
        semantic/methodcall-field-initializer-throws.test \
        semantic/methodcall-invalid-argument-lambda.test \
+       semantic/methodcall-invocation-invalid.test \
        semantic/methodcall-void-expression.test \
        semantic/methodcall-yield-with-begin.test \
        semantic/objectcreation-abstract-class.test \
diff --git a/tests/semantic/methodcall-invocation-invalid.test b/tests/semantic/methodcall-invocation-invalid.test
new file mode 100644 (file)
index 0000000..a83ed4d
--- /dev/null
@@ -0,0 +1,13 @@
+Invalid Code
+
+interface Bar {
+}
+
+class Foo {
+       public Bar bar { get; set; }
+}
+
+void main() {
+       var foo = new Foo ();
+       print ("%d", foo.bar ());
+}
index 36f82f93baf1c4efa3cd8386c50acdcd5a4b6fc7..9f652b884a145e250534b4fd51b15bf7edf6db0a 100644 (file)
@@ -152,7 +152,7 @@ public class Vala.MethodCall : Expression, CallableExpression {
                        if (!(m.coroutine && !is_yield_expression && ((MemberAccess) call).member_name != "end")) {
                                m.get_error_types (collection, source_reference);
                        }
-               } else if (mtype is ObjectType) {
+               } else if (mtype is ObjectType && mtype.type_symbol is Class) {
                        // constructor
                        unowned Class cl = (Class) ((ObjectType) mtype).type_symbol;
                        unowned Method m = cl.default_construction_method;