]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/panel: novatek-nt35950: fix return value check in nt35950_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 29 Oct 2024 12:39:57 +0000 (20:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Dec 2024 12:52:57 +0000 (13:52 +0100)
[ Upstream commit f8fd0968eff52cf092c0d517d17507ea2f6e5ea5 ]

mipi_dsi_device_register_full() never returns NULL pointer, it
will return ERR_PTR() when it fails, so replace the check with
IS_ERR().

Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20241029123957.1588-1-yangyingliang@huaweicloud.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241029123957.1588-1-yangyingliang@huaweicloud.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/panel/panel-novatek-nt35950.c

index ec2780be74d109f73e54b2bf7f90c924f1bdbc59..a92a7cd697f445d1a2ab31dd03260b2bab183ec1 100644 (file)
@@ -577,9 +577,9 @@ static int nt35950_probe(struct mipi_dsi_device *dsi)
                        return dev_err_probe(dev, -EPROBE_DEFER, "Cannot get secondary DSI host\n");
 
                nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info);
-               if (!nt->dsi[1]) {
+               if (IS_ERR(nt->dsi[1])) {
                        dev_err(dev, "Cannot get secondary DSI node\n");
-                       return -ENODEV;
+                       return PTR_ERR(nt->dsi[1]);
                }
                num_dsis++;
        }