]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
coverity: Check fstat return value
authorStéphane Graber <stgraber@ubuntu.com>
Fri, 14 Feb 2014 21:03:00 +0000 (16:03 -0500)
committerStéphane Graber <stgraber@ubuntu.com>
Sat, 15 Feb 2014 00:13:46 +0000 (19:13 -0500)
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
src/lxc/lxc_user_nic.c

index 60176b1749aace0c327a89077a18093df32ce3ef..a2f0c96b90297ba43bfdda8979051098e34e2f0d 100644 (file)
@@ -306,7 +306,10 @@ static bool cull_entries(int fd, char *me, char *t, char *br)
 
        nic = alloca(100);
 
-       fstat(fd, &sb);
+       if (fstat(fd, &sb) < 0) {
+               fprintf(stderr, "Failed to fstat: %s", strerror(errno));
+               return false;
+       }
        len = sb.st_size;
        if (len == 0)
                return true;
@@ -383,7 +386,10 @@ static bool get_nic_if_avail(int fd, char *me, int pid, char *intype, char *br,
        if (allowed == 0)
                return false;
 
-       fstat(fd, &sb);
+       if (fstat(fd, &sb) < 0) {
+               fprintf(stderr, "Failed to fstat: %s", strerror(errno));
+               return false;
+       }
        len = sb.st_size;
        if (len != 0) {
                buf = mmap(NULL, len, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);