smb: client: fix incomplete backport in cfids_invalidation_worker()

The previous commit bdb596ceb4b7 ("smb: client: fix potential UAF in
smb2_close_cached_fid()") was an incomplete backport and missed one
kref_put() call in cfids_invalidation_worker() that should have been
converted to close_cached_dir().

Fixes: 065bd6241227 ("smb: client: fix potential UAF in smb2_close_cached_fid()")"
Signed-off-by: Henrique Carvalho <henrique.carvalho@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/smb/client/cached_dir.c b/fs/smb/client/cached_dir.c
index 3fefe5e7b16fadf87641bb2840fbf64d0050d07c..e92a61e934e44726694854c94411caade3c36cf8 100644 (file)
--- a/fs/smb/client/cached_dir.c
+++ b/fs/smb/client/cached_dir.c
@@ -727,7 +727,7 @@ static void cfids_invalidation_worker(struct work_struct *work)
        list_for_each_entry_safe(cfid, q, &entry, entry) {
                list_del(&cfid->entry);
                /* Drop the ref-count acquired in invalidate_all_cached_dirs */
-               kref_put(&cfid->refcount, smb2_close_cached_fid);
+               close_cached_dir(cfid);
        }
 }