]> git.ipfire.org Git - thirdparty/ipxe.git/commitdiff
[eoib] Avoid passing a NULL I/O buffer to netdev_tx_complete_err()
authorMichael Brown <mcb30@ipxe.org>
Tue, 21 Mar 2017 13:07:10 +0000 (15:07 +0200)
committerMichael Brown <mcb30@ipxe.org>
Tue, 21 Mar 2017 13:07:10 +0000 (15:07 +0200)
Report errors in eoib_duplicate() via netdev_tx_err() rather than
netdev_tx_complete_err(), since netdev_tx_complete_err() accepts only
valid I/O buffers that are currently in the network device's transmit
queue.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/drivers/net/eoib.c

index f58e74b7d496ce1d5e84a850533fe1c81f690fbb..e824783724ab12e4e65b5d67a4c59ea1d882e90c 100644 (file)
@@ -870,8 +870,9 @@ static void eoib_duplicate ( struct eoib_device *eoib,
 
  err_post_send:
  err_path:
+       list_del ( &copy->list );
  err_alloc:
-       netdev_tx_complete_err ( netdev, copy, rc );
+       netdev_tx_err ( netdev, copy, rc );
 }
 
 /**