newgrp: fix possible FILE leak on error

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/login-utils/newgrp.c b/login-utils/newgrp.c
index d8ae2cf99dff07ee4ac695e49ad317287ceb306f..85cba7752a40ec75f276dc53d26920f12ba8bee5 100644 (file)
--- a/login-utils/newgrp.c
+++ b/login-utils/newgrp.c
@@ -28,9 +28,13 @@ static char *get_gshadow_pwd(char *groupname)
 {
        char buf[BUFSIZ];
        char *pwd = NULL;
-       FILE *f = fopen(_PATH_GSHADOW, "r");
+       FILE *f;
 
-       if (groupname == NULL || *groupname == '\0' || f == NULL)
+       if (groupname == NULL || *groupname == '\0')
+               return NULL;
+
+       f = fopen(_PATH_GSHADOW, "r");
+       if (!f)
                return NULL;
 
        while (fgets(buf, sizeof buf, f)) {