]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
mod_skinny: avoid truncation of non-null-terminated strings in protocol
authorNathan Neulinger <nneul@neulinger.org>
Wed, 17 Sep 2014 16:13:15 +0000 (11:13 -0500)
committerNathan Neulinger <nneul@neulinger.org>
Wed, 17 Sep 2014 16:13:15 +0000 (11:13 -0500)
src/mod/endpoints/mod_skinny/skinny_protocol.c

index 5f3a8313459008267cb04c9b1b30fa7d6acd3090..fc4ee532a02cff041485e9fb24a3184bee62f500 100644 (file)
@@ -501,7 +501,7 @@ switch_status_t perform_send_register_ack(listener_t *listener,
        skinny_create_message(message, REGISTER_ACK_MESSAGE, reg_ack);
 
        message->data.reg_ack.keep_alive = keep_alive;
-       switch_copy_string(message->data.reg_ack.date_format, date_format, 6);
+       memcpy(message->data.reg_ack.date_format, date_format, 6);
        switch_copy_string(message->data.reg_ack.reserved, reserved, 2);
        message->data.reg_ack.secondary_keep_alive = keep_alive;
        switch_copy_string(message->data.reg_ack.reserved2, reserved2, 4);
@@ -871,7 +871,7 @@ switch_status_t perform_send_version(listener_t *listener,
 
        skinny_create_message(message, VERSION_MESSAGE, version);
 
-       switch_copy_string(message->data.version.version, version, 16);
+       memcpy(message->data.version.version, version, 16);
 
        skinny_log_l_ffl(listener, file, func, line, SWITCH_LOG_DEBUG,
                "Send Version with Version(%s)\n", version);