mfd: qnap-mcu: Handle errors returned from qnap_mcu_write

[ Upstream commit bf2de43060d528e52e372c63182a94b95c80d305 ]

qnap_mcu_write can return errors and those were not checked before.
So do that now.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250804130726.3180806-3-heiko@sntech.de
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/mfd/qnap-mcu.c b/drivers/mfd/qnap-mcu.c
index 89a8a1913d42dd25c9a6602f240903b47e5489ad..9d3edc3e7d93b19cd3a9d4c698cb64f8f21fae35 100644 (file)
--- a/drivers/mfd/qnap-mcu.c
+++ b/drivers/mfd/qnap-mcu.c
@@ -163,7 +163,11 @@ int qnap_mcu_exec(struct qnap_mcu *mcu,
        reply->received = 0;
        reinit_completion(&reply->done);
 
-       qnap_mcu_write(mcu, cmd_data, cmd_data_size);
+       ret = qnap_mcu_write(mcu, cmd_data, cmd_data_size);
+       if (ret < 0) {
+               mutex_unlock(&mcu->bus_lock);
+               return ret;
+       }
 
        serdev_device_wait_until_sent(mcu->serdev, msecs_to_jiffies(QNAP_MCU_TIMEOUT_MS));