]> git.ipfire.org Git - thirdparty/knot-dns.git/commitdiff
keymgr: fix possible NULL dereference when parsing import-key params (clang analyzer)
authorDaniel Salzman <daniel.salzman@nic.cz>
Wed, 17 Sep 2025 06:44:21 +0000 (08:44 +0200)
committerDaniel Salzman <daniel.salzman@nic.cz>
Wed, 17 Sep 2025 06:45:08 +0000 (08:45 +0200)
src/utils/keymgr/functions.c

index 7276a93bf4fe7984ea5963cd8ac848c7a731a8ba..f60e497a186866bb92850fc2d2e95b1818e569c0 100644 (file)
@@ -180,7 +180,7 @@ static bool genkeyargs(int argc, char *argv[], bool just_timing,
                                ERR2("invalid size: '%s'", argv[i] + 5);
                                return false;
                        }
-               } else if (!just_timing && same_command(argv[i], "addtopolicy=", true)) {
+               } else if (!just_timing && same_command(argv[i], "addtopolicy=", true) && addtopolicy != NULL) {
                        *addtopolicy = argv[i] + 12;
                } else if (same_command_bool(argv[i], "ksk", &res)) {
                        bitmap_set(flags, DNSKEY_GENERATE_KSK, res);