x86/resctrl: Discover hardware telemetry events

Each CPU collects data for telemetry events that it sends to the nearest
telemetry event aggregator either when the value of MSR_IA32_PQR_ASSOC.RMID
changes, or when a two millisecond timer expires.

There is a feature type ("energy" or "perf"), GUID, and MMIO region associated
with each aggregator. This combination links to an XML description of the
set of telemetry events tracked by the aggregator. XML files are published
by Intel in a GitHub repository¹.

The telemetry event aggregators maintain per-RMID per-event counts of the
total seen for all the CPUs. There may be multiple telemetry event aggregators
per package.

There are separate sets of aggregators for each feature type. Aggregators
in a set may have different GUIDs. All aggregators with the same feature
type and GUID are symmetric keeping counts for the same set of events for
the CPUs that provide data to them.

The XML file for each aggregator provides the following information:
0) Feature type of the events ("perf" or "energy")
1) Which telemetry events are tracked by the aggregator.
2) The order in which the event counters appear for each RMID.
3) The value type of each event counter (integer or fixed-point).
4) The number of RMIDs supported.
5) Which additional aggregator status registers are included.
6) The total size of the MMIO region for an aggregator.

Introduce struct event_group that condenses the relevant information from
an XML file. Hereafter an "event group" refers to a group of events of a
particular feature type (event_group::pfname set to "energy" or "perf") with
a particular GUID.

Use event_group::pfname to determine the feature id needed to obtain the
aggregator details. It will later be used in console messages and with the
rdt= boot parameter.

The INTEL_PMT_TELEMETRY driver enumerates support for telemetry events.
This driver provides intel_pmt_get_regions_by_feature() to list all available
telemetry event aggregators of a given feature type. The list includes the
"guid", the base address in MMIO space for the region where the event counters
are exposed, and the package id where the all the CPUs that report to this
aggregator are located.

Call INTEL_PMT_TELEMETRY's intel_pmt_get_regions_by_feature() for each event
group to obtain a private copy of that event group's aggregator data. Duplicate
the aggregator data between event groups that have the same feature type
but different GUID. Further processing on this private copy will be unique
to the event group.

  ¹https://github.com/intel/Intel-PMT

  [ bp: Zap text explaining the code, s/guid/GUID/g ]

Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/20251217172121.12030-1-tony.luck@intel.com

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 80527299f859aaab7e357f59a410ac436daafd1f..0d874a92daeda7062054b9fb9e2c42a079f5ca36 100644 (file)
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -540,6 +540,19 @@ config X86_CPU_RESCTRL
 
          Say N if unsure.
 
+config X86_CPU_RESCTRL_INTEL_AET
+       bool "Intel Application Energy Telemetry"
+       depends on X86_CPU_RESCTRL && CPU_SUP_INTEL && INTEL_PMT_TELEMETRY=y && INTEL_TPMI=y
+       help
+         Enable per-RMID telemetry events in resctrl.
+
+         Intel feature that collects per-RMID execution data
+         about energy consumption, measure of frequency independent
+         activity and other performance metrics. Data is aggregated
+         per package.
+
+         Say N if unsure.
+
 config X86_FRED
        bool "Flexible Return and Event Delivery"
        depends on X86_64

diff --git a/arch/x86/kernel/cpu/resctrl/Makefile b/arch/x86/kernel/cpu/resctrl/Makefile
index d8a04b195da212990289aa95d50fe681a0eea44c..273ddfa308366d1db3b410db8ce7f1c3d1a1090c 100644 (file)
--- a/arch/x86/kernel/cpu/resctrl/Makefile
+++ b/arch/x86/kernel/cpu/resctrl/Makefile
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_X86_CPU_RESCTRL)          += core.o rdtgroup.o monitor.o
 obj-$(CONFIG_X86_CPU_RESCTRL)          += ctrlmondata.o
+obj-$(CONFIG_X86_CPU_RESCTRL_INTEL_AET)        += intel_aet.o
 obj-$(CONFIG_RESCTRL_FS_PSEUDO_LOCK)   += pseudo_lock.o
 
 # To allow define_trace.h's recursive include:

diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index f3d7e2263630cb00e99898984d1161d462cbc094..595f7eae9294de1743ca85724ac68b195152e9f0 100644 (file)
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -738,6 +738,8 @@ static int resctrl_arch_offline_cpu(unsigned int cpu)
 
 void resctrl_arch_pre_mount(void)
 {
+       if (!intel_aet_get_events())
+               return;
 }
 
 enum {
@@ -1099,6 +1101,8 @@ late_initcall(resctrl_arch_late_init);
 
 static void __exit resctrl_arch_exit(void)
 {
+       intel_aet_exit();
+
        cpuhp_remove_state(rdt_online);
 
        resctrl_exit();

diff --git a/arch/x86/kernel/cpu/resctrl/intel_aet.c b/arch/x86/kernel/cpu/resctrl/intel_aet.c
new file mode 100644 (file)
index 0000000..4045647
--- /dev/null
+++ b/arch/x86/kernel/cpu/resctrl/intel_aet.c
@@ -0,0 +1,109 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Resource Director Technology(RDT)
+ * - Intel Application Energy Telemetry
+ *
+ * Copyright (C) 2025 Intel Corporation
+ *
+ * Author:
+ *    Tony Luck <tony.luck@intel.com>
+ */
+
+#define pr_fmt(fmt)   "resctrl: " fmt
+
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/intel_pmt_features.h>
+#include <linux/intel_vsec.h>
+#include <linux/resctrl.h>
+#include <linux/stddef.h>
+
+#include "internal.h"
+
+/**
+ * struct event_group - Events with the same feature type ("energy" or "perf") and GUID.
+ * @pfname:            PMT feature name ("energy" or "perf") of this event group.
+ * @pfg:               Points to the aggregated telemetry space information
+ *                     returned by the intel_pmt_get_regions_by_feature()
+ *                     call to the INTEL_PMT_TELEMETRY driver that contains
+ *                     data for all telemetry regions of type @pfname.
+ *                     Valid if the system supports the event group,
+ *                     NULL otherwise.
+ */
+struct event_group {
+       /* Data fields for additional structures to manage this group. */
+       const char                      *pfname;
+       struct pmt_feature_group        *pfg;
+};
+
+static struct event_group *known_event_groups[] = {
+};
+
+#define for_each_event_group(_peg)                                             \
+       for (_peg = known_event_groups;                                         \
+            _peg < &known_event_groups[ARRAY_SIZE(known_event_groups)];        \
+            _peg++)
+
+/* Stub for now */
+static bool enable_events(struct event_group *e, struct pmt_feature_group *p)
+{
+       return false;
+}
+
+static enum pmt_feature_id lookup_pfid(const char *pfname)
+{
+       if (!strcmp(pfname, "energy"))
+               return FEATURE_PER_RMID_ENERGY_TELEM;
+       else if (!strcmp(pfname, "perf"))
+               return FEATURE_PER_RMID_PERF_TELEM;
+
+       pr_warn("Unknown PMT feature name '%s'\n", pfname);
+
+       return FEATURE_INVALID;
+}
+
+/*
+ * Request a copy of struct pmt_feature_group for each event group. If there is
+ * one, the returned structure has an array of telemetry_region structures,
+ * each element of the array describes one telemetry aggregator. The
+ * telemetry aggregators may have different GUIDs so obtain duplicate struct
+ * pmt_feature_group for event groups with same feature type but different
+ * GUID. Post-processing ensures an event group can only use the telemetry
+ * aggregators that match its GUID. An event group keeps a pointer to its
+ * struct pmt_feature_group to indicate that its events are successfully
+ * enabled.
+ */
+bool intel_aet_get_events(void)
+{
+       struct pmt_feature_group *p;
+       enum pmt_feature_id pfid;
+       struct event_group **peg;
+       bool ret = false;
+
+       for_each_event_group(peg) {
+               pfid = lookup_pfid((*peg)->pfname);
+               p = intel_pmt_get_regions_by_feature(pfid);
+               if (IS_ERR_OR_NULL(p))
+                       continue;
+               if (enable_events(*peg, p)) {
+                       (*peg)->pfg = p;
+                       ret = true;
+               } else {
+                       intel_pmt_put_feature_group(p);
+               }
+       }
+
+       return ret;
+}
+
+void __exit intel_aet_exit(void)
+{
+       struct event_group **peg;
+
+       for_each_event_group(peg) {
+               if ((*peg)->pfg) {
+                       intel_pmt_put_feature_group((*peg)->pfg);
+                       (*peg)->pfg = NULL;
+               }
+       }
+}

diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index 11d06995810e0bc13fadd372223349b94518bb81..f2e6e3577df03264ebf054a42c955641ba7bcc58 100644 (file)
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -222,4 +222,12 @@ void __init intel_rdt_mbm_apply_quirk(void);
 void rdt_domain_reconfigure_cdp(struct rdt_resource *r);
 void resctrl_arch_mbm_cntr_assign_set_one(struct rdt_resource *r);
 
+#ifdef CONFIG_X86_CPU_RESCTRL_INTEL_AET
+bool intel_aet_get_events(void);
+void __exit intel_aet_exit(void);
+#else
+static inline bool intel_aet_get_events(void) { return false; }
+static inline void __exit intel_aet_exit(void) { }
+#endif
+
 #endif /* _ASM_X86_RESCTRL_INTERNAL_H */