]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
testLXCCapsInit: Cleanup
authorTim Wiederhake <twiederh@redhat.com>
Mon, 8 Nov 2021 11:44:11 +0000 (12:44 +0100)
committerTim Wiederhake <twiederh@redhat.com>
Mon, 8 Nov 2021 13:32:32 +0000 (14:32 +0100)
Remove unnecessary label and goto. Cleanup line breaks.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
tests/testutilslxc.c

index 857407dfb2eb329153d76d7e32403a51cda351c6..ac7a01a4e8ee92db9bfe2e95d8c6410fd9b5c97f 100644 (file)
 virCaps *
 testLXCCapsInit(void)
 {
-    virCaps *caps;
+    g_autoptr(virCaps) caps = NULL;
     virCapsGuest *guest;
 
-    if ((caps = virCapabilitiesNew(VIR_ARCH_X86_64,
-                                   false, false)) == NULL)
+    if ((caps = virCapabilitiesNew(VIR_ARCH_X86_64, false, false)) == NULL)
         return NULL;
 
     guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_EXE,
@@ -33,20 +32,14 @@ testLXCCapsInit(void)
     virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_LXC, NULL, NULL, 0, NULL);
 
     if (virTestGetDebug()) {
-        g_autofree char *caps_str = NULL;
-
-        caps_str = virCapabilitiesFormatXML(caps);
+        g_autofree char *caps_str = virCapabilitiesFormatXML(caps);
         if (!caps_str)
-            goto error;
+            return NULL;
 
         VIR_TEST_DEBUG("LXC driver capabilities:\n%s", caps_str);
     }
 
-    return caps;
-
- error:
-    virObjectUnref(caps);
-    return NULL;
+    return g_steal_pointer(&caps);
 }