commands/probe: Fix a resource leak when probing disks

Every other return statement in this code is calling grub_device_close()
to clean up dev before returning. This one should do that too.

Fixes: CID 292443
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

diff --git a/grub-core/commands/probe.c b/grub-core/commands/probe.c
index 573bdf603b4e170029901b21cfd0b944b18f34d1..e53b611786df96ce4d179f1cffeaad50e0db0a5e 100644 (file)
--- a/grub-core/commands/probe.c
+++ b/grub-core/commands/probe.c
@@ -111,7 +111,11 @@ grub_cmd_probe (grub_extcmd_context_t ctxt, int argc, char **args)
          grub_disk_t disk = grub_disk_open(dev->disk->name);
 
          if (!disk)
-           return grub_errno;
+           {
+             grub_device_close (dev);
+             return grub_errno;
+           }
+
          if (grub_strcmp(dev->disk->partition->partmap->name, "gpt") == 0)
            {
              struct grub_gpt_partentry entry;