]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cxl/region: Add @hpa_range argument to function cxl_calc_interleave_pos()
authorRobert Richter <rrichter@amd.com>
Wed, 14 Jan 2026 16:48:22 +0000 (17:48 +0100)
committerDave Jiang <dave.jiang@intel.com>
Tue, 3 Feb 2026 17:52:58 +0000 (10:52 -0700)
cxl_calc_interleave_pos() uses the endpoint decoder's HPA range to
determine its interleaving position. This requires the endpoint
decoders to be an SPA, which is not the case for systems that need
address translation.

Add a separate @hpa_range argument to function
cxl_calc_interleave_pos() to specify the address range. Now it is
possible to pass the SPA translated address range of an endpoint
decoder to function cxl_calc_interleave_pos().

Refactor only, no functional changes.

Patch is a prerequisite to implement address translation.

Reviewed-by: Gregory Price <gourry@gourry.net>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Tested-by: Gregory Price <gourry@gourry.net>
Signed-off-by: Robert Richter <rrichter@amd.com>
Link: https://patch.msgid.link/20260114164837.1076338-7-rrichter@amd.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/region.c

index 5ae77e9feb4dca888c8986c71c24bc6e0d410378..60d2d1dae2aa32c59951e8c204e92ec3921f05ad 100644 (file)
@@ -1878,6 +1878,7 @@ static int find_pos_and_ways(struct cxl_port *port, struct range *range,
 /**
  * cxl_calc_interleave_pos() - calculate an endpoint position in a region
  * @cxled: endpoint decoder member of given region
+ * @hpa_range: translated HPA range of the endpoint
  *
  * The endpoint position is calculated by traversing the topology from
  * the endpoint to the root decoder and iteratively applying this
@@ -1890,11 +1891,11 @@ static int find_pos_and_ways(struct cxl_port *port, struct range *range,
  * Return: position >= 0 on success
  *        -ENXIO on failure
  */
-static int cxl_calc_interleave_pos(struct cxl_endpoint_decoder *cxled)
+static int cxl_calc_interleave_pos(struct cxl_endpoint_decoder *cxled,
+                                  struct range *hpa_range)
 {
        struct cxl_port *iter, *port = cxled_to_port(cxled);
        struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
-       struct range *range = &cxled->cxld.hpa_range;
        int parent_ways = 0, parent_pos = 0, pos = 0;
        int rc;
 
@@ -1932,7 +1933,8 @@ static int cxl_calc_interleave_pos(struct cxl_endpoint_decoder *cxled)
                if (is_cxl_root(iter))
                        break;
 
-               rc = find_pos_and_ways(iter, range, &parent_pos, &parent_ways);
+               rc = find_pos_and_ways(iter, hpa_range, &parent_pos,
+                                      &parent_ways);
                if (rc)
                        return rc;
 
@@ -1942,7 +1944,7 @@ static int cxl_calc_interleave_pos(struct cxl_endpoint_decoder *cxled)
        dev_dbg(&cxlmd->dev,
                "decoder:%s parent:%s port:%s range:%#llx-%#llx pos:%d\n",
                dev_name(&cxled->cxld.dev), dev_name(cxlmd->dev.parent),
-               dev_name(&port->dev), range->start, range->end, pos);
+               dev_name(&port->dev), hpa_range->start, hpa_range->end, pos);
 
        return pos;
 }
@@ -1955,7 +1957,7 @@ static int cxl_region_sort_targets(struct cxl_region *cxlr)
        for (i = 0; i < p->nr_targets; i++) {
                struct cxl_endpoint_decoder *cxled = p->targets[i];
 
-               cxled->pos = cxl_calc_interleave_pos(cxled);
+               cxled->pos = cxl_calc_interleave_pos(cxled, &cxlr->hpa_range);
                /*
                 * Record that sorting failed, but still continue to calc
                 * cxled->pos so that follow-on code paths can reliably
@@ -2139,7 +2141,7 @@ static int cxl_region_attach(struct cxl_region *cxlr,
                struct cxl_endpoint_decoder *cxled = p->targets[i];
                int test_pos;
 
-               test_pos = cxl_calc_interleave_pos(cxled);
+               test_pos = cxl_calc_interleave_pos(cxled, &cxlr->hpa_range);
                dev_dbg(&cxled->cxld.dev,
                        "Test cxl_calc_interleave_pos(): %s test_pos:%d cxled->pos:%d\n",
                        (test_pos == cxled->pos) ? "success" : "fail",