]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: stmmac: remove .get_tx_ls()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 27 Feb 2026 09:53:24 +0000 (09:53 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 3 Mar 2026 02:35:05 +0000 (18:35 -0800)
No code calls stmmac_get_tx_ls(). Remove this macro, its associated
function pointer, and all implementations.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vvuXE-0000000Avmr-0eB0@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
drivers/net/ethernet/stmicro/stmmac/enh_desc.c
drivers/net/ethernet/stmicro/stmmac/hwif.h
drivers/net/ethernet/stmicro/stmmac/norm_desc.c

index b8fe4ad883e5bc7d3ecd137265a6f92749b0c7a8..56a88b71def92e6be53a438f99d93517d1b9344f 100644 (file)
@@ -191,12 +191,6 @@ static void dwmac4_set_rx_owner(struct dma_desc *p, int disable_rx_ic)
        p->des3 |= cpu_to_le32(flags);
 }
 
-static int dwmac4_get_tx_ls(struct dma_desc *p)
-{
-       return (le32_to_cpu(p->des3) & TDES3_LAST_DESCRIPTOR)
-               >> TDES3_LAST_DESCRIPTOR_SHIFT;
-}
-
 static u16 dwmac4_wrback_get_rx_vlan_tci(struct dma_desc *p)
 {
        return (le32_to_cpu(p->des0) & RDES0_VLAN_TAG_MASK);
@@ -549,7 +543,6 @@ const struct stmmac_desc_ops dwmac4_desc_ops = {
        .get_tx_len = dwmac4_rd_get_tx_len,
        .set_tx_owner = dwmac4_set_tx_owner,
        .set_rx_owner = dwmac4_set_rx_owner,
-       .get_tx_ls = dwmac4_get_tx_ls,
        .get_rx_vlan_tci = dwmac4_wrback_get_rx_vlan_tci,
        .get_rx_vlan_valid = dwmac4_wrback_get_rx_vlan_valid,
        .get_rx_frame_len = dwmac4_wrback_get_rx_frame_len,
index 8bf37351393094194e26c398b36ca2c4ac0368e2..f5deceb052d7f1e92fe91b6780f203b8746a7226 100644 (file)
@@ -60,11 +60,6 @@ static void dwxgmac2_set_rx_owner(struct dma_desc *p, int disable_rx_ic)
        p->des3 |= cpu_to_le32(flags);
 }
 
-static int dwxgmac2_get_tx_ls(struct dma_desc *p)
-{
-       return (le32_to_cpu(p->des3) & XGMAC_RDES3_LD) > 0;
-}
-
 static u16 dwxgmac2_wrback_get_rx_vlan_tci(struct dma_desc *p)
 {
        return le32_to_cpu(p->des0) & XGMAC_RDES0_VLAN_TAG_MASK;
@@ -353,7 +348,6 @@ const struct stmmac_desc_ops dwxgmac210_desc_ops = {
        .get_tx_len = dwxgmac2_get_tx_len,
        .set_tx_owner = dwxgmac2_set_tx_owner,
        .set_rx_owner = dwxgmac2_set_rx_owner,
-       .get_tx_ls = dwxgmac2_get_tx_ls,
        .get_rx_vlan_tci = dwxgmac2_wrback_get_rx_vlan_tci,
        .get_rx_vlan_valid = dwxgmac2_wrback_get_rx_vlan_valid,
        .get_rx_frame_len = dwxgmac2_get_rx_frame_len,
index 77b2cb34aa0e424805a35c4ebb4bfe2a21393360..3c241c5699eddaf4b7f000485e8ef83d3e41d24d 100644 (file)
@@ -287,11 +287,6 @@ static void enh_desc_set_rx_owner(struct dma_desc *p, int disable_rx_ic)
        p->des0 |= cpu_to_le32(RDES0_OWN);
 }
 
-static int enh_desc_get_tx_ls(struct dma_desc *p)
-{
-       return (le32_to_cpu(p->des0) & ETDES0_LAST_SEGMENT) >> 29;
-}
-
 static void enh_desc_release_tx_desc(struct dma_desc *p, int mode)
 {
        int ter = (le32_to_cpu(p->des0) & ETDES0_END_RING) >> 21;
@@ -446,7 +441,6 @@ const struct stmmac_desc_ops enh_desc_ops = {
        .release_tx_desc = enh_desc_release_tx_desc,
        .prepare_tx_desc = enh_desc_prepare_tx_desc,
        .set_tx_ic = enh_desc_set_tx_ic,
-       .get_tx_ls = enh_desc_get_tx_ls,
        .set_tx_owner = enh_desc_set_tx_owner,
        .set_rx_owner = enh_desc_set_rx_owner,
        .get_rx_frame_len = enh_desc_get_rx_frame_len,
index 50ca8dcea2fd47d9e32235631ca911276e38e475..e317f64a0fcc6f12039d093c2cd6ab472220fb7d 100644 (file)
@@ -56,8 +56,6 @@ struct stmmac_desc_ops {
        /* Clear interrupt on tx frame completion. When this bit is
         * set an interrupt happens as soon as the frame is transmitted */
        void (*set_tx_ic)(struct dma_desc *p);
-       /* Last tx segment reports the transmit status */
-       int (*get_tx_ls)(struct dma_desc *p);
        /* Get the tag of the descriptor */
        u16 (*get_rx_vlan_tci)(struct dma_desc *p);
        /* Get the valid status of descriptor */
@@ -119,8 +117,6 @@ struct stmmac_desc_ops {
        stmmac_do_void_callback(__priv, desc, release_tx_desc, __args)
 #define stmmac_set_tx_ic(__priv, __args...) \
        stmmac_do_void_callback(__priv, desc, set_tx_ic, __args)
-#define stmmac_get_tx_ls(__priv, __args...) \
-       stmmac_do_callback(__priv, desc, get_tx_ls, __args)
 #define stmmac_get_rx_vlan_tci(__priv, __args...) \
        stmmac_do_callback(__priv, desc, get_rx_vlan_tci, __args)
 #define stmmac_get_rx_vlan_valid(__priv, __args...) \
index e9face06b950cfbfb49b8ae4066bc6a7fc11c762..621bc1deb4e55421f0810b30f872f419bd103f82 100644 (file)
@@ -151,11 +151,6 @@ static void ndesc_set_rx_owner(struct dma_desc *p, int disable_rx_ic)
        p->des0 |= cpu_to_le32(RDES0_OWN);
 }
 
-static int ndesc_get_tx_ls(struct dma_desc *p)
-{
-       return (le32_to_cpu(p->des1) & TDES1_LAST_SEGMENT) >> 30;
-}
-
 static void ndesc_release_tx_desc(struct dma_desc *p, int mode)
 {
        int ter = (le32_to_cpu(p->des1) & TDES1_END_RING) >> 25;
@@ -292,7 +287,6 @@ const struct stmmac_desc_ops ndesc_ops = {
        .release_tx_desc = ndesc_release_tx_desc,
        .prepare_tx_desc = ndesc_prepare_tx_desc,
        .set_tx_ic = ndesc_set_tx_ic,
-       .get_tx_ls = ndesc_get_tx_ls,
        .set_tx_owner = ndesc_set_tx_owner,
        .set_rx_owner = ndesc_set_rx_owner,
        .get_rx_frame_len = ndesc_get_rx_frame_len,