Move DoStatement transformation into the CCodeTransformer

Fixes https://gitlab.gnome.org/GNOME/vala/issues/27

diff --git a/codegen/valaccodetransformer.vala b/codegen/valaccodetransformer.vala
index 0096dfb0b6106a8da35a206e95b4dffeae2240ba..9e036ee02584883e6882acc6839a2c8af88f6438 100644 (file)
--- a/codegen/valaccodetransformer.vala
+++ b/codegen/valaccodetransformer.vala
@@ -81,6 +81,29 @@ public class Vala.CCodeTransformer : CodeTransformer {
                end_replace_statement ();
        }
 
+       public override void visit_do_statement (DoStatement stmt) {
+               // convert to simple loop
+               begin_replace_statement (stmt);
+
+               b.open_loop ();
+               // do not generate variable and if block if condition is always true
+               if (!always_true (stmt.condition)) {
+                       var notfirst = b.add_temp_declaration (null, expression ("false"));
+                       b.open_if (expression (notfirst));
+                       b.open_if (new UnaryExpression (UnaryOperator.LOGICAL_NEGATION, stmt.condition, stmt.source_reference));
+                       b.add_break ();
+                       b.close ();
+                       b.add_else ();
+                       b.add_assignment (expression (notfirst), expression ("true"));
+                       b.close ();
+               }
+               stmt.body.checked = false;
+               b.add_statement (stmt.body);
+               b.close ();
+
+               end_replace_statement ();
+       }
+
        public override void visit_expression (Expression expr) {
                if (expr in context.analyzer.replaced_nodes) {
                        return;

diff --git a/vala/valadostatement.vala b/vala/valadostatement.vala
index f34e223584655ff6b196f4ebe8578314680719cd..b65ac2b7f2409c7de286c00705d7f037fb734533 100644 (file)
--- a/vala/valadostatement.vala
+++ b/vala/valadostatement.vala
@@ -81,11 +81,6 @@ public class Vala.DoStatement : CodeNode, Statement {
                visitor.visit_end_full_expression (condition);
        }
 
-       bool always_true (Expression condition) {
-               var literal = condition as BooleanLiteral;
-               return (literal != null && literal.value);
-       }
-
        public override void replace_expression (Expression old_node, Expression new_node) {
                if (condition == old_node) {
                        condition = new_node;
@@ -99,46 +94,25 @@ public class Vala.DoStatement : CodeNode, Statement {
 
                checked = true;
 
-               // convert to simple loop
-
-               // do not generate variable and if block if condition is always true
-               if (always_true (condition)) {
-                       var loop = new Loop (body, source_reference);
-
-                       var parent_block = (Block) parent_node;
-                       parent_block.replace_statement (this, loop);
+               condition.target_type = context.analyzer.bool_type.copy ();
 
-                       if (!loop.check (context)) {
-                               error = true;
-                       }
+               condition.check (context);
 
-                       return !error;
+               if (condition.error) {
+                       /* if there was an error in the condition, skip this check */
+                       error = true;
+                       return false;
                }
 
-               var block = new Block (source_reference);
-
-               var first_local = new LocalVariable (context.analyzer.bool_type.copy (), get_temp_name (), new BooleanLiteral (true, source_reference), source_reference);
-               block.add_statement (new DeclarationStatement (first_local, source_reference));
-
-               var if_condition = new UnaryExpression (UnaryOperator.LOGICAL_NEGATION, condition, condition.source_reference);
-               var true_block = new Block (condition.source_reference);
-               true_block.add_statement (new BreakStatement (condition.source_reference));
-               var if_stmt = new IfStatement (if_condition, true_block, null, condition.source_reference);
-
-               var condition_block = new Block (condition.source_reference);
-               condition_block.add_statement (if_stmt);
-
-               var first_if = new IfStatement (new UnaryExpression (UnaryOperator.LOGICAL_NEGATION, new MemberAccess.simple (first_local.name, source_reference), source_reference), condition_block, null, source_reference);
-               body.insert_statement (0, first_if);
-               body.insert_statement (1, new ExpressionStatement (new Assignment (new MemberAccess.simple (first_local.name, source_reference), new BooleanLiteral (false, source_reference), AssignmentOperator.SIMPLE, source_reference), source_reference));
-
-               block.add_statement (new Loop (body, source_reference));
-
-               var parent_block = (Block) parent_node;
-               parent_block.replace_statement (this, block);
+               if (condition.value_type == null || !condition.value_type.compatible (context.analyzer.bool_type)) {
+                       error = true;
+                       Report.error (condition.source_reference, "Condition must be boolean");
+                       return false;
+               }
 
-               if (!block.check (context)) {
+               if (!body.check (context)) {
                        error = true;
+                       return false;
                }
 
                return !error;

diff --git a/vala/valaflowanalyzer.vala b/vala/valaflowanalyzer.vala
index b6a49d203224995de27cec09939ef42938c588fb..9b1489ce0656643901926d801bcb268d53b681f0 100644 (file)
--- a/vala/valaflowanalyzer.vala
+++ b/vala/valaflowanalyzer.vala
@@ -804,6 +804,57 @@ public class Vala.FlowAnalyzer : CodeVisitor {
                jump_stack.remove_at (jump_stack.size - 1);
        }
 
+       public override void visit_do_statement (DoStatement stmt) {
+               if (unreachable (stmt)) {
+                       return;
+               }
+
+               var body_block = new BasicBlock ();
+               all_basic_blocks.add (body_block);
+               current_block.connect (body_block);
+               current_block = body_block;
+
+               var loop_block = new BasicBlock ();
+               all_basic_blocks.add (loop_block);
+               jump_stack.add (new JumpTarget.continue_target (loop_block));
+               var after_loop_block = new BasicBlock ();
+               all_basic_blocks.add (after_loop_block);
+               jump_stack.add (new JumpTarget.break_target (after_loop_block));
+
+               // body
+               stmt.body.accept (this);
+
+               // end of loop block reachable?
+               if (current_block != null) {
+                       current_block.connect (loop_block);
+               }
+
+               // condition
+               current_block = loop_block;
+               loop_block.add_node (stmt.condition);
+               handle_errors (stmt.condition);
+
+               if (!always_false (stmt.condition)) {
+                       loop_block.connect (body_block);
+               }
+
+               if (!always_true (stmt.condition)) {
+                       loop_block.connect (after_loop_block);
+               }
+
+               // after loop block reachable?
+               if (after_loop_block.get_predecessors ().size == 0) {
+                       // after loop block not reachable
+                       mark_unreachable ();
+               } else {
+                       // after loop block reachable
+                       current_block = after_loop_block;
+               }
+
+               jump_stack.remove_at (jump_stack.size - 1);
+               jump_stack.remove_at (jump_stack.size - 1);
+       }
+
        public override void visit_foreach_statement (ForeachStatement stmt) {
                if (unreachable (stmt)) {
                        return;