]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
unix-manager: display errors like errors
authorEric Leblond <eric@regit.org>
Mon, 14 Dec 2015 14:04:47 +0000 (15:04 +0100)
committerVictor Julien <victor@inliniac.net>
Thu, 17 Dec 2015 15:28:44 +0000 (16:28 +0100)
Not being able to setup the output directory or file is an error so
it should be printed as such.

src/runmode-unix-socket.c

index 06a71869d495fff5394f5574e9f77f0766dd795b..46aa3100a64fb44cb44950168318881f87715996 100644 (file)
@@ -346,13 +346,15 @@ TmEcode UnixSocketPcapFilesCheck(void *data)
         unix_manager_file_task_running = 1;
         this->running = 1;
         if (ConfSet("pcap-file.file", cfile->filename) != 1) {
-            SCLogInfo("Can not set working file to '%s'", cfile->filename);
+            SCLogError(SC_ERR_INVALID_ARGUMENTS,
+                       "Can not set working file to '%s'", cfile->filename);
             PcapFilesFree(cfile);
             return TM_ECODE_FAILED;
         }
         if (cfile->output_dir) {
             if (ConfSet("default-log-dir", cfile->output_dir) != 1) {
-                SCLogInfo("Can not set output dir to '%s'", cfile->output_dir);
+                SCLogError(SC_ERR_INVALID_ARGUMENTS,
+                           "Can not set output dir to '%s'", cfile->output_dir);
                 PcapFilesFree(cfile);
                 return TM_ECODE_FAILED;
             }
@@ -361,7 +363,8 @@ TmEcode UnixSocketPcapFilesCheck(void *data)
             char tstr[16] = "";
             snprintf(tstr, sizeof(tstr), "%d", cfile->tenant_id);
             if (ConfSet("pcap-file.tenant-id", tstr) != 1) {
-                SCLogInfo("Can not set working tenant-id to '%s'", tstr);
+                SCLogError(SC_ERR_INVALID_ARGUMENTS,
+                           "Can not set working tenant-id to '%s'", tstr);
                 PcapFilesFree(cfile);
                 return TM_ECODE_FAILED;
             }