wifi: iwlwifi: add suppress_cmd_error_once() API

Add iwl_trans_suppress_cmd_error_once() function to be called by the op
modes instead of directly checking the trans status bits.
This hides the trans internal implementation details from callers.

Signed-off-by: Rotem Kerem <rotem.kerem@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250710212632.e061ae241fd3.Ie2043c4e237196ebcfe195006d3d76371de48a55@changeid

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h
index ac37d9613ade756dbdcdbab073981ce56d788ba1..aa0c8ca828054f522a1c3749b64d30b7de6da043 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h
@@ -1230,6 +1230,11 @@ static inline u16 iwl_trans_get_num_rbds(struct iwl_trans *trans)
        return result;
 }
 
+static inline void iwl_trans_suppress_cmd_error_once(struct iwl_trans *trans)
+{
+       set_bit(STATUS_SUPPRESS_CMD_ERROR_ONCE, &trans->status);
+}
+
 /*****************************************************
  * PCIe handling
  *****************************************************/

diff --git a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
index 75cc1d8bb90c5a0838d432361b2900a9d86e707f..cc052b0aa53ff33f0a70c48ce19c28c6deb217b1 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
@@ -86,7 +86,7 @@ static ssize_t iwl_dbgfs_fw_restart_write(struct iwl_mld *mld, char *buf,
 
        if (count == 6 && !strcmp(buf, "nolog\n")) {
                mld->fw_status.do_not_dump_once = true;
-               set_bit(STATUS_SUPPRESS_CMD_ERROR_ONCE, &mld->trans->status);
+               iwl_trans_suppress_cmd_error_once(mld->trans);
        }
 
        /* take the return value to make compiler happy - it will

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
index 86a87ea89916905e294b7b0f487ea91ae0533336..f0e184c8a81a474a02b4a6bebcc506005ec4dfda 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
@@ -1134,7 +1134,7 @@ static ssize_t iwl_dbgfs_fw_restart_write(struct iwl_mvm *mvm, char *buf,
 
        if (count == 6 && !strcmp(buf, "nolog\n")) {
                set_bit(IWL_MVM_STATUS_SUPPRESS_ERROR_LOG_ONCE, &mvm->status);
-               set_bit(STATUS_SUPPRESS_CMD_ERROR_ONCE, &mvm->trans->status);
+               iwl_trans_suppress_cmd_error_once(mvm->trans);
        }
 
        /* take the return value to make compiler happy - it will fail anyway */