]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
clk: rockchip: Fix memory leak in rockchip_clk_register_pll()
authorXiu Jianfeng <xiujianfeng@huawei.com>
Wed, 23 Nov 2022 09:12:01 +0000 (17:12 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Jan 2023 11:07:17 +0000 (12:07 +0100)
[ Upstream commit 739a6a6bbdb793bd57938cb24aa5a6df89983546 ]

If clk_register() fails, @pll->rate_table may have allocated memory by
kmemdup(), so it needs to be freed, otherwise will cause memory leak
issue, this patch fixes it.

Fixes: 90c590254051 ("clk: rockchip: add clock type for pll clocks and pll used on rk3066")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Link: https://lore.kernel.org/r/20221123091201.199819-1-xiujianfeng@huawei.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/rockchip/clk-pll.c

index 9c1373e81683bebec4c0968b30036c5b175e8028..347d659c8f3473eb466c85a2dbf3cf9bd9339ab5 100644 (file)
@@ -957,6 +957,7 @@ struct clk *rockchip_clk_register_pll(struct rockchip_clk_provider *ctx,
        return mux_clk;
 
 err_pll:
+       kfree(pll->rate_table);
        clk_unregister(mux_clk);
        mux_clk = pll_clk;
 err_mux: