]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: deprecate QEMU_CAPS_DTB
authorJán Tomko <jtomko@redhat.com>
Thu, 29 Mar 2018 10:51:55 +0000 (12:51 +0200)
committerJán Tomko <jtomko@redhat.com>
Tue, 17 Apr 2018 11:01:10 +0000 (13:01 +0200)
Implied by QEMU >= 1.2.0.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
30 files changed:
src/qemu/qemu_capabilities.c
src/qemu/qemu_capabilities.h
src/qemu/qemu_command.c
tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml
tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml
tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml
tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
tests/qemuxml2argvtest.c
tests/qemuxml2xmltest.c

index 4d07ad0a7b7df8800d8ba7bf01756937a40fce84..9024b0d30a0c5388af18ef81195f956d385af67f 100644 (file)
@@ -3625,7 +3625,6 @@ static qemuMonitorCallbacks callbacks = {
 static void
 virQEMUCapsInitQMPBasic(virQEMUCapsPtr qemuCaps)
 {
-    virQEMUCapsSet(qemuCaps, QEMU_CAPS_DTB);
     virQEMUCapsSet(qemuCaps, QEMU_CAPS_IPV6_MIGRATION);
     virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_OPT);
     virQEMUCapsSet(qemuCaps, QEMU_CAPS_DUMP_GUEST_CORE);
index 01fed7073d58bb3bc42cb2b6169797b0d5680134..c2d9f9fbd6216d2bdcee6e2202dd3cbfd9f33ea6 100644 (file)
@@ -233,7 +233,7 @@ typedef enum {
     QEMU_CAPS_OBJECT_RNG_RANDOM, /* the rng-random backend for virtio rng */
     QEMU_CAPS_OBJECT_RNG_EGD, /* EGD protocol daemon for rng */
     QEMU_CAPS_VIRTIO_CCW, /* -device virtio-*-ccw */
-    QEMU_CAPS_DTB, /* -dtb file */
+    X_QEMU_CAPS_DTB, /* -dtb file */
     QEMU_CAPS_SCSI_MEGASAS, /* -device megasas */
 
     /* 135 */
index 8d0ce148776cbd9ee4785f3b1d012d3138631bf6..d1fcdf5c93bbd5f57df242c5a8f216d8e4c8ae32 100644 (file)
@@ -6348,15 +6348,8 @@ qemuBuildBootCommandLine(virCommandPtr cmd,
         virCommandAddArgList(cmd, "-initrd", def->os.initrd, NULL);
     if (def->os.cmdline)
         virCommandAddArgList(cmd, "-append", def->os.cmdline, NULL);
-    if (def->os.dtb) {
-        if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DTB)) {
-            virCommandAddArgList(cmd, "-dtb", def->os.dtb, NULL);
-        } else {
-            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                           _("dtb is not supported with this QEMU binary"));
-            goto error;
-        }
-    }
+    if (def->os.dtb)
+        virCommandAddArgList(cmd, "-dtb", def->os.dtb, NULL);
     if (def->os.slic_table) {
         virBuffer buf = VIR_BUFFER_INITIALIZER;
         virCommandAddArg(cmd, "-acpitable");
index 69ee300ce7b456d9594556a4136def3f6fc31537..21f0d7ded8142163af6292af9bd089f0f268d205 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 21c4ad973093dda09cb1652de4be96edbb014ca9..a903d80e2c9514c2b40e66f939a9ee8185d294ae 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index f3ee50041d9e76c11a8197f50897514063ff886a..197f43846d1e3f5c7c4f0816ac73089b1c3323aa 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index f794d7f10392a46b39dac6afa4ee29a599a09390..c8d2daa778109ee31cf64574428c2681ed78844e 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index ba986ba43f47abc06f8307b4eb24b3c98717cfc4..1d9b663268ffec0f13d0e7e011d07421c9cc7559 100644 (file)
@@ -52,7 +52,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 5d8579b058cbe03fae6fd08d06eeb81a0004ecb2..4b717bf5f05a0ea95a2a10e391d447dbe5e098c1 100644 (file)
@@ -51,7 +51,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index f1640c3e5bcdb7111405a133a7f8503952885a86..225f3803cbf3e4bea20c16347c92ae041bb8da30 100644 (file)
@@ -35,7 +35,6 @@
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
   <flag name='virtio-ccw'/>
-  <flag name='dtb'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
   <flag name='machine-usb-opt'/>
index d8d8439e5f7730adf1ff6841c2f589271f7da470..0573cd47187c01eeea4fb8521d4447310aaf74bf 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 17fff019bb80bd39183ca0672f4edabcea6a4683..32d4fefc975ec08bdd0913502ca3feb9a2dd612e 100644 (file)
@@ -35,7 +35,6 @@
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
   <flag name='virtio-ccw'/>
-  <flag name='dtb'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
   <flag name='machine-usb-opt'/>
index fe979d74bbc38a8df1a040325a54494d17578770..40e9920f9e925569b04c5c2122fd171b26bfc630 100644 (file)
@@ -52,7 +52,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 6a658b73c32a1e1bb79e435bb0ca32edad74d2b9..19cd3efa1aafd40f855b96d77238471c9e69914f 100644 (file)
@@ -51,7 +51,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 2b7d0061372101e3fd351a4bfe2bdac07bfda2d1..586b68290023903509ee56292445c97da1d9f4da 100644 (file)
@@ -35,7 +35,6 @@
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
   <flag name='virtio-ccw'/>
-  <flag name='dtb'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
   <flag name='machine-usb-opt'/>
index a701d2304b867d71b9e98dba67eb9df8db094362..26db434e1914be3ef8737ebbd4ecb0b8696aa109 100644 (file)
@@ -66,7 +66,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 9c86bf079451630f3493bbd9eb7c2e2647e97ea9..ff5f820eb1ba2c38d079cfab590a1927b84a9ec8 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 8062bcf75ed0dd818aa2e8ddbc61a84826e85c62..e9aef8e36fe7a2bdb31090f27b0d8460bf98e9a7 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 663bb01bf8d5e44075a8b7b9c36a816df1de3d49..815ad2e7f168fb3bfe1ceb8f3da35493035a6cd8 100644 (file)
@@ -54,7 +54,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index dfe686c5ca43f47ff7847365259d805761a26f3a..da7de1d7fb03385c5a2d09df15d5135006a30ee6 100644 (file)
@@ -51,7 +51,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 6b0f544892ca05960a00007687ac85ec29e435d4..77cc540d7dacf89554d7d6bab1bfcba6cc7bcda6 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 0069f639e84effd8a70f28b42b70d81c02f2db1f..cfdee30b3ff0038462650b34072cc20585b15e0a 100644 (file)
@@ -35,7 +35,6 @@
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
   <flag name='virtio-ccw'/>
-  <flag name='dtb'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
   <flag name='machine-usb-opt'/>
index 489b82d4b27f93c23dfaa368e6efd8d537f9d534..ba7a5ebb58a37ee4d1d4895a424ff057efff6e4c 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index b1413fe34946d80eb724aa88586166abd275a9f3..c547abef737ceef50c5c81cc20229d28fb774a2f 100644 (file)
@@ -35,7 +35,6 @@
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
   <flag name='virtio-ccw'/>
-  <flag name='dtb'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
   <flag name='machine-usb-opt'/>
index 4d57068535d48b4f87e24443fb4fcaffad86a953..4d4e66160dc6a1d11257302f017996abe17d55cb 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index c4647a6d752a06f3e888032443bb36e19ad7b3d1..c37d90fac5f8b588c64689517b97f79e235bb2f6 100644 (file)
@@ -50,7 +50,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index 4c88f62dfaf866b09de544e662ac7b7fc4e5df20..665122e72a7d9acd3360ffaf3a9971f666927214 100644 (file)
@@ -35,7 +35,6 @@
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
   <flag name='virtio-ccw'/>
-  <flag name='dtb'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
   <flag name='machine-usb-opt'/>
index 896813522faba4b44e449503d8ef359a2a024961..5c0e8cddf500586e466338fee4c4146f8008b1a4 100644 (file)
@@ -68,7 +68,6 @@
   <flag name='virtio-rng'/>
   <flag name='rng-random'/>
   <flag name='rng-egd'/>
-  <flag name='dtb'/>
   <flag name='megasas'/>
   <flag name='ipv6-migration'/>
   <flag name='machine-opt'/>
index d2d6e5ed90f11f67887dec01c003cc4d830ceb15..152e0d2c18fe9fce2a7ec7871aa32594b8b17e4c 100644 (file)
@@ -1459,7 +1459,7 @@ mymain(void)
     DO_TEST("balloon-ccw-deflate",
             QEMU_CAPS_VIRTIO_BALLOON_AUTODEFLATE);
     DO_TEST("balloon-mmio-deflate",
-            QEMU_CAPS_DTB, QEMU_CAPS_DEVICE_VIRTIO_MMIO,
+            QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_VIRTIO_BALLOON_AUTODEFLATE);
     DO_TEST("balloon-device-deflate-off",
             QEMU_CAPS_VIRTIO_BALLOON_AUTODEFLATE);
@@ -1939,8 +1939,7 @@ mymain(void)
             QEMU_CAPS_DEVICE_SCLPCONSOLE);
 
     DO_TEST("ppc-dtb",
-            QEMU_CAPS_KVM,
-            QEMU_CAPS_DTB);
+            QEMU_CAPS_KVM);
     DO_TEST("ppce500-serial",
             QEMU_CAPS_KVM);
 
@@ -2308,22 +2307,17 @@ mymain(void)
             QEMU_CAPS_DEVICE_QXL,
             QEMU_CAPS_Q35_PCI_HOLE64_SIZE);
 
-    DO_TEST("arm-vexpressa9-nodevs",
-            QEMU_CAPS_DTB);
-    DO_TEST("arm-vexpressa9-basic",
-            QEMU_CAPS_DTB);
+    DO_TEST("arm-vexpressa9-nodevs", NONE);
+    DO_TEST("arm-vexpressa9-basic", NONE);
     DO_TEST("arm-vexpressa9-virtio",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM);
     DO_TEST("arm-virt-virtio",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_PL011,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM);
 
     DO_TEST("aarch64-virt-virtio",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_PL011,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM);
@@ -2333,7 +2327,6 @@ mymain(void)
        but virtio-mmio is always used unless PCI addresses are manually
        specified. */
     DO_TEST("aarch64-virtio-pci-default",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM,
@@ -2343,7 +2336,6 @@ mymain(void)
             QEMU_CAPS_DEVICE_PL011,
             QEMU_CAPS_VIRTIO_SCSI);
     DO_TEST("aarch64-virt-2.6-virtio-pci-default",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM,
             QEMU_CAPS_OBJECT_GPEX, QEMU_CAPS_DEVICE_PCI_BRIDGE,
@@ -2353,7 +2345,6 @@ mymain(void)
     /* Example of using virtio-pci with no explicit PCI controller
        but with manual PCI addresses */
     DO_TEST("aarch64-virtio-pci-manual-addresses",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM,
             QEMU_CAPS_OBJECT_GPEX, QEMU_CAPS_DEVICE_PCI_BRIDGE,
@@ -2372,7 +2363,6 @@ mymain(void)
             QEMU_CAPS_DEVICE_VIRTIO_GPU, QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE,
             QEMU_CAPS_VNC);
     DO_TEST("aarch64-aavmf-virtio-mmio",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM);
     DO_TEST("aarch64-virt-default-nic",
index 08fc54d19bd5e2cee63d410a078af5b1a3145826..52cbc621e94988df7b1100351b1db01a4832ad0b 100644 (file)
@@ -1022,11 +1022,9 @@ mymain(void)
     DO_TEST("smbios-multiple-type2", NONE);
 
     DO_TEST("aarch64-aavmf-virtio-mmio",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM);
     DO_TEST("aarch64-virtio-pci-default",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM,
@@ -1035,7 +1033,6 @@ mymain(void)
             QEMU_CAPS_DEVICE_IOH3420,
             QEMU_CAPS_VIRTIO_SCSI);
     DO_TEST("aarch64-virtio-pci-manual-addresses",
-            QEMU_CAPS_DTB,
             QEMU_CAPS_DEVICE_VIRTIO_MMIO,
             QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM,
             QEMU_CAPS_OBJECT_GPEX, QEMU_CAPS_DEVICE_PCI_BRIDGE,