]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[master] addressed cpp-check issues detected on Jenkins. trac4283_base trac4523_base
authorTomek Mrugalski <tomasz@isc.org>
Thu, 23 Jun 2016 14:54:40 +0000 (16:54 +0200)
committerTomek Mrugalski <tomasz@isc.org>
Thu, 23 Jun 2016 14:54:40 +0000 (16:54 +0200)
src/lib/dhcpsrv/cql_connection.cc
src/lib/dhcpsrv/cql_lease_mgr.cc

index 2b92631184be9289db9c4ee6dd9f131a489413cd..1dec234ebf53133a768c44aeee22446c47575f5f 100644 (file)
@@ -150,7 +150,6 @@ CqlConnection::openDatabase() {
 void
 CqlConnection::prepareStatements(CqlTaggedStatement *statements) {
     CassError rc = CASS_OK;
-    CassFuture* future = NULL;
     uint32_t size = 0;
     tagged_statements_ = statements;
     for (; tagged_statements_[size].params_; size++);
@@ -158,7 +157,7 @@ CqlConnection::prepareStatements(CqlTaggedStatement *statements) {
     for (uint32_t i = 0; i < size; i++) {
         const char* query = tagged_statements_[i].text_;
 
-        future = cass_session_prepare(session_, query);
+        CassFuture* future = cass_session_prepare(session_, query);
         cass_future_wait(future);
         std::string error;
         checkStatementError(error, future, i, "could not prepare statement");
index e788976bf75b973934645671a004237c50b0dd53..6ccab4f91cef0984eeeacd56c7c894baf9f7e378 100644 (file)
@@ -1185,7 +1185,6 @@ CqlLeaseMgr::bindData(CassStatement* statement, const StatementIndex stindex,
 void
 CqlLeaseMgr::getData(const CassRow* row, const int pindex, CqlDataArray& data,
         CqlDataArray& size, const int dindex, const SqlExchange& exchange) {
-    const CassValue* value;
     if (pindex >= exchange.parameters_.size()) {
         return;
     }
@@ -1194,7 +1193,7 @@ CqlLeaseMgr::getData(const CassRow* row, const int pindex, CqlDataArray& data,
     if (std::distance(range.first, range.second) > 0) {
         std::string name = (*range.first)->name_;
         ExchangeDataType type = (*range.first)->type_;
-        value = cass_row_get_column_by_name(row, name.c_str());
+        const CassValue* value = cass_row_get_column_by_name(row, name.c_str());
         if (NULL == value) {
             isc_throw(BadValue, "column name " << name << " doesn't exist");
         }