]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
spi: cs42l43: Don't support sidecar properties on device tree systems
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Mon, 23 Feb 2026 10:07:17 +0000 (10:07 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 23 Feb 2026 12:17:51 +0000 (12:17 +0000)
On some systems the cs42l43 has amplifiers attached to its
SPI controller that are not properly defined in ACPI. However,
this exists to provide compatibility with existing Windows ACPI.

On device tree systems this functionality should never be used,
there is no reason not to specify the amplifiers properly through
device tree.  Make this more clear by only allowing the "sidecar"
functionality to be used on non-DT systems.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20260223100717.4011114-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cs42l43.c

index a4a650c8d7405e5a2ced10651cd017aaee2c4133..68f208ef1e01f9f95831466a84b9715a3f83d6f8 100644 (file)
@@ -367,10 +367,10 @@ static int cs42l43_spi_probe(struct platform_device *pdev)
                ret = devm_add_action_or_reset(priv->dev, cs42l43_release_of_node, fwnode);
                if (ret)
                        return ret;
+       } else {
+               fwnode_property_read_u32(xu_fwnode, "01fa-sidecar-instances", &nsidecars);
        }
 
-       fwnode_property_read_u32(xu_fwnode, "01fa-sidecar-instances", &nsidecars);
-
        /*
         * Depending on the value of nsidecars we either create a software node
         * or assign an fwnode. We don't want software node to be attached to